<div dir="auto">I'll be unavailable the next 2 weeks, feel free to do it if you want!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jun 9, 2023, 21:10 Tom Honermann via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">tahonermann added a comment.<br>
<br>
@cor3ntin, sorry for failing to keep up with reviews; I know this has already been committed. I did spot a couple of typos should you feel inclined to address them.<br>
<br>
<br>
<br>
================<br>
Comment at: clang/lib/Lex/Lexer.cpp:2695<br>
+  // diagnostic only once per entire ill-formed subsequence to avoid<br>
+  // emiting to many diagnostics (see <a href="http://unicode.org/review/pr-121.html" rel="noreferrer noreferrer" target="_blank">http://unicode.org/review/pr-121.html</a>).<br>
+  bool UnicodeDecodingAlreadyDiagnosed = false;<br>
----------------<br>
<br>
<br>
<br>
================<br>
Comment at: clang/lib/Lex/Lexer.cpp:2398<br>
+  // diagnostic only once per entire ill-formed subsequence to avoid<br>
+  // emiting to many diagnostics (see <a href="http://unicode.org/review/pr-121.html" rel="noreferrer noreferrer" target="_blank">http://unicode.org/review/pr-121.html</a>).<br>
+  bool UnicodeDecodingAlreadyDiagnosed = false;<br>
----------------<br>
<br>
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D128059/new/" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D128059/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D128059" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D128059</a><br>
<br>
</blockquote></div>