<div dir="ltr">How does this interact with the CHECK-NOTs above it. Does it check that they don't appear before the __riscv_i but would be allowed after it?<div><br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature">~Craig</div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Feb 14, 2023 at 9:03 AM Alex Bradbury via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Alex Bradbury<br>
Date: 2023-02-14T17:02:32Z<br>
New Revision: d05e1e99b1d62cf1f8ab37f83dd2f377328dd9c5<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/d05e1e99b1d62cf1f8ab37f83dd2f377328dd9c5" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/d05e1e99b1d62cf1f8ab37f83dd2f377328dd9c5</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/d05e1e99b1d62cf1f8ab37f83dd2f377328dd9c5.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/d05e1e99b1d62cf1f8ab37f83dd2f377328dd9c5.diff</a><br>
<br>
LOG: [clang][test][RISCV] Check for __riscv_i in riscv-target-features.c<br>
<br>
This was overlooked, even though we have comprehensive tests for all the<br>
other __riscv_fooext defines.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    clang/test/Preprocessor/riscv-target-features.c<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/clang/test/Preprocessor/riscv-target-features.c b/clang/test/Preprocessor/riscv-target-features.c<br>
index 3f643a2fb587..139c84b08f16 100644<br>
--- a/clang/test/Preprocessor/riscv-target-features.c<br>
+++ b/clang/test/Preprocessor/riscv-target-features.c<br>
@@ -49,6 +49,7 @@<br>
 // CHECK-NOT: __riscv_zcd {{.*$}}<br>
 // CHECK-NOT: __riscv_zcf {{.*$}}<br>
 // CHECK-NOT: __riscv_h {{.*$}}<br>
+// CHECK: __riscv_i 2000000{{$}}<br>
<br>
 // RUN: %clang -target riscv32-unknown-linux-gnu -march=rv32im -x c -E -dM %s \<br>
 // RUN: -o - | FileCheck --check-prefix=CHECK-M-EXT %s<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>