<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Hi Shubham,</p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I found one issue in the change.</p>
<p class="MsoNormal">But I don’t have a Mac environment to test.</p>
<p class="MsoNormal">Could you help to test if this fix the issue?</p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The patch is in attachment.</p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks</p>
<p class="MsoNormal">Xiang</p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Sent from <a href="https://go.microsoft.com/fwlink/?LinkId=550986">
Mail</a> for Windows</p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="border:none;padding:0in"><b>From: </b><a href="mailto:reviews@reviews.llvm.org">Shubham Sandeep Rastogi via Phabricator</a><br>
<b>Sent: </b>Wednesday, June 1, 2022 11:28 PM<br>
<b>To: </b><a href="mailto:python3kgae@outlook.com">python3kgae@outlook.com</a>; <a href="mailto:sven.vanhaastregt@arm.com">
sven.vanhaastregt@arm.com</a>; <a href="mailto:andrew.savonichev@gmail.com">andrew.savonichev@gmail.com</a>;
<a href="mailto:chris.bieneman@me.com">chris.bieneman@me.com</a>; <a href="mailto:goyoroth@gmail.com">
goyoroth@gmail.com</a>; <a href="mailto:anastasia.stulova@arm.com">anastasia.stulova@arm.com</a><br>
<b>Cc: </b><a href="mailto:srastogi22@apple.com">srastogi22@apple.com</a>; <a href="mailto:thakis@chromium.org">
thakis@chromium.org</a>; <a href="mailto:maskray@google.com">maskray@google.com</a>;
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>; <a href="mailto:mgorny@gentoo.org">
mgorny@gentoo.org</a>; <a href="mailto:bhuvanendra.kumarn@amd.com">bhuvanendra.kumarn@amd.com</a>;
<a href="mailto:1135831309@qq.com">1135831309@qq.com</a>; <a href="mailto:gandhi21299@gmail.com">
gandhi21299@gmail.com</a>; <a href="mailto:aeubanks@google.com">aeubanks@google.com</a>;
<a href="mailto:mlekena@skidmore.edu">mlekena@skidmore.edu</a>; <a href="mailto:blitzrakete@gmail.com">
blitzrakete@gmail.com</a>; <a href="mailto:shenhan@google.com">shenhan@google.com</a>;
<a href="mailto:david.green@arm.com">david.green@arm.com</a>; <a href="mailto:simon.moll@emea.nec.com">
simon.moll@emea.nec.com</a><br>
<b>Subject: </b>[PATCH] D125052: [HLSL] Enable vector types for hlsl.</p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">rastogishubham added a comment.<br>
<br>
Hi, this patch causes an issue with the CMake Xcode build configuration, if I try to use xcode as the generator with CMake, using the build command:<br>
<br>
xcrun cmake -G Xcode -DCMAKE_BUILD_TYPE:STRING=Debug -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DLLVM_ENABLE_PROJECTS='clang;' -DCMAKE_IGNORE_PATH="/usr/lib;/usr/local/lib;/lib" -DLLVM_TARGETS_TO_BUILD="X86;ARM;AArch64"
../llvm<br>
<br>
I get:<br>
<br>
CMake Error in /Users/shubham/Development/llvm-project/clang/lib/Headers/CMakeLists.txt:<br>
The custom command generating<br>
<br>
/Users/shubham/Development/llvm-project/build/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/clang/15.0.0/include/hlsl.h<br>
<br>
is attached to multiple targets:<br>
<br>
hlsl-resource-headers<br>
clang-resource-headers<br>
<br>
but none of these is a common dependency of the other(s). This is not<br>
allowed by the Xcode "new build system".<br>
<br>
<br>
CMake Error in /Users/shubham/Development/llvm-project/third-party/benchmark/CMakeLists.txt:<br>
The custom command generating<br>
<br>
/Users/shubham/Development/llvm-project/build/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/clang/15.0.0/include/hlsl.h<br>
<br>
is attached to multiple targets:<br>
<br>
hlsl-resource-headers<br>
clang-resource-headers<br>
<br>
but none of these is a common dependency of the other(s). This is not<br>
allowed by the Xcode "new build system".<br>
<br>
<br>
CMake Generate step failed. Build files cannot be regenerated correctly.<br>
<br>
This is similar to the issue that was found in this patch: <a href="https://reviews.llvm.org/D123498">
https://reviews.llvm.org/D123498</a><br>
<br>
<br>
Repository:<br>
rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D125052/new/">https://reviews.llvm.org/D125052/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D125052">https://reviews.llvm.org/D125052</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>