<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Xiang,<div class=""><br class=""></div><div class="">I would be more than happy to test the fix for you :). Though it is 11:45 pm for me now and I am going to bed. But I can take a look tomorrow.</div><div class=""><br class=""></div><div class="">Thanks,</div><div class=""><br class=""></div><div class="">Shubham</div><div class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jun 1, 2022, at 11:42 PM, stan li <<a href="mailto:python3kgae@outlook.com" class="">python3kgae@outlook.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta charset="UTF-8" class=""><div class="WordSection1" style="page: WordSection1; caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Hi Shubham,</div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class="">I found one issue in the change.</div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class="">But I don’t have a Mac environment to test.</div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Could you help to test if this fix the issue?</div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class="">The patch is in attachment.</div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Thanks</div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Xiang</div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Sent from<span class="Apple-converted-space"> </span><a href="https://go.microsoft.com/fwlink/?LinkId=550986" style="color: blue; text-decoration: underline;" class="">Mail</a><span class="Apple-converted-space"> </span>for Windows</div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="border-style: solid none none; border-top-width: 1pt; border-top-color: rgb(225, 225, 225); padding: 3pt 0in 0in;" class=""><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif; border: none; padding: 0in;" class=""><b class="">From:<span class="Apple-converted-space"> </span></b><a href="mailto:reviews@reviews.llvm.org" style="color: blue; text-decoration: underline;" class="">Shubham Sandeep Rastogi via Phabricator</a><br class=""><b class="">Sent:<span class="Apple-converted-space"> </span></b>Wednesday, June 1, 2022 11:28 PM<br class=""><b class="">To:<span class="Apple-converted-space"> </span></b><a href="mailto:python3kgae@outlook.com" style="color: blue; text-decoration: underline;" class="">python3kgae@outlook.com</a>;<span class="Apple-converted-space"> </span><a href="mailto:sven.vanhaastregt@arm.com" style="color: blue; text-decoration: underline;" class="">sven.vanhaastregt@arm.com</a>;<span class="Apple-converted-space"> </span><a href="mailto:andrew.savonichev@gmail.com" style="color: blue; text-decoration: underline;" class="">andrew.savonichev@gmail.com</a>;<span class="Apple-converted-space"> </span><a href="mailto:chris.bieneman@me.com" style="color: blue; text-decoration: underline;" class="">chris.bieneman@me.com</a>;<span class="Apple-converted-space"> </span><a href="mailto:goyoroth@gmail.com" style="color: blue; text-decoration: underline;" class="">goyoroth@gmail.com</a>;<span class="Apple-converted-space"> </span><a href="mailto:anastasia.stulova@arm.com" style="color: blue; text-decoration: underline;" class="">anastasia.stulova@arm.com</a><br class=""><b class="">Cc:<span class="Apple-converted-space"> </span></b><a href="mailto:srastogi22@apple.com" style="color: blue; text-decoration: underline;" class="">srastogi22@apple.com</a>;<span class="Apple-converted-space"> </span><a href="mailto:thakis@chromium.org" style="color: blue; text-decoration: underline;" class="">thakis@chromium.org</a>;<span class="Apple-converted-space"> </span><a href="mailto:maskray@google.com" style="color: blue; text-decoration: underline;" class="">maskray@google.com</a>;<span class="Apple-converted-space"> </span><a href="mailto:cfe-commits@lists.llvm.org" style="color: blue; text-decoration: underline;" class="">cfe-commits@lists.llvm.org</a>;<span class="Apple-converted-space"> </span><a href="mailto:mgorny@gentoo.org" style="color: blue; text-decoration: underline;" class="">mgorny@gentoo.org</a>;<span class="Apple-converted-space"> </span><a href="mailto:bhuvanendra.kumarn@amd.com" style="color: blue; text-decoration: underline;" class="">bhuvanendra.kumarn@amd.com</a>;<a href="mailto:1135831309@qq.com" style="color: blue; text-decoration: underline;" class="">1135831309@qq.com</a>;<span class="Apple-converted-space"> </span><a href="mailto:gandhi21299@gmail.com" style="color: blue; text-decoration: underline;" class="">gandhi21299@gmail.com</a>;<span class="Apple-converted-space"> </span><a href="mailto:aeubanks@google.com" style="color: blue; text-decoration: underline;" class="">aeubanks@google.com</a>;<span class="Apple-converted-space"> </span><a href="mailto:mlekena@skidmore.edu" style="color: blue; text-decoration: underline;" class="">mlekena@skidmore.edu</a>;<span class="Apple-converted-space"> </span><a href="mailto:blitzrakete@gmail.com" style="color: blue; text-decoration: underline;" class="">blitzrakete@gmail.com</a>;<span class="Apple-converted-space"> </span><a href="mailto:shenhan@google.com" style="color: blue; text-decoration: underline;" class="">shenhan@google.com</a>;<a href="mailto:david.green@arm.com" style="color: blue; text-decoration: underline;" class="">david.green@arm.com</a>;<span class="Apple-converted-space"> </span><a href="mailto:simon.moll@emea.nec.com" style="color: blue; text-decoration: underline;" class="">simon.moll@emea.nec.com</a><br class=""><b class="">Subject:<span class="Apple-converted-space"> </span></b>[PATCH] D125052: [HLSL] Enable vector types for hlsl.</div></div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><p class="MsoNormal" style="margin: 0in 0in 12pt; font-size: 11pt; font-family: Calibri, sans-serif;">rastogishubham added a comment.<br class=""><br class="">Hi, this patch causes an issue with the CMake Xcode build configuration, if I try to use xcode as the generator with CMake, using the build command:<br class=""><br class="">xcrun cmake -G Xcode -DCMAKE_BUILD_TYPE:STRING=Debug -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DLLVM_ENABLE_PROJECTS='clang;' -DCMAKE_IGNORE_PATH="/usr/lib;/usr/local/lib;/lib" -DLLVM_TARGETS_TO_BUILD="X86;ARM;AArch64" ../llvm<br class=""><br class="">I get:<br class=""><br class=""> CMake Error in /Users/shubham/Development/llvm-project/clang/lib/Headers/CMakeLists.txt:<br class=""> The custom command generating<br class=""> <span class="Apple-converted-space"> </span><br class=""> /Users/shubham/Development/llvm-project/build/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/clang/15.0.0/include/hlsl.h<br class=""> <span class="Apple-converted-space"> </span><br class=""> is attached to multiple targets:<br class=""> <span class="Apple-converted-space"> </span><br class=""> hlsl-resource-headers<br class=""> clang-resource-headers<br class=""> <span class="Apple-converted-space"> </span><br class=""> but none of these is a common dependency of the other(s). This is not<br class=""> allowed by the Xcode "new build system".<br class=""> <span class="Apple-converted-space"> </span><br class=""> <span class="Apple-converted-space"> </span><br class=""> CMake Error in /Users/shubham/Development/llvm-project/third-party/benchmark/CMakeLists.txt:<br class=""> The custom command generating<br class=""> <span class="Apple-converted-space"> </span><br class=""> /Users/shubham/Development/llvm-project/build/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/clang/15.0.0/include/hlsl.h<br class=""> <span class="Apple-converted-space"> </span><br class=""> is attached to multiple targets:<br class=""> <span class="Apple-converted-space"> </span><br class=""> hlsl-resource-headers<br class=""> clang-resource-headers<br class=""> <span class="Apple-converted-space"> </span><br class=""> but none of these is a common dependency of the other(s). This is not<br class=""> allowed by the Xcode "new build system".<br class=""> <span class="Apple-converted-space"> </span><br class=""> <span class="Apple-converted-space"> </span><br class=""> CMake Generate step failed. Build files cannot be regenerated correctly.<br class=""><br class="">This is similar to the issue that was found in this patch:<span class="Apple-converted-space"> </span><a href="https://reviews.llvm.org/D123498" style="color: blue; text-decoration: underline;" class="">https://reviews.llvm.org/D123498</a><br class=""><br class=""><br class="">Repository:<br class=""> rG LLVM Github Monorepo<br class=""><br class="">CHANGES SINCE LAST ACTION<br class=""> <span class="Apple-converted-space"> </span><a href="https://reviews.llvm.org/D125052/new/" style="color: blue; text-decoration: underline;" class="">https://reviews.llvm.org/D125052/new/</a><br class=""><br class=""><a href="https://reviews.llvm.org/D125052" style="color: blue; text-decoration: underline;" class="">https://reviews.llvm.org/D125052</a><o:p class=""></o:p></p><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div></div><span id="cid:7A53F1A0-747C-4271-A41A-ECF087D06295"><header_install.patch></span></div></blockquote></div><br class=""></div></body></html>