<div dir="auto">I thought I caught all of them, too! I encourage someone with commit rights to land the missing five characters "std::" right now, and/or I'll be able to take my own look in about 6 hours from now.<div dir="auto"><br></div><div dir="auto">Arthur<br><div dir="auto"><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 24, 2022, 2:06 PM Corentin Jabot via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">cor3ntin added a comment.<br>
<br>
In D119670#3343726 <<a href="https://reviews.llvm.org/D119670#3343726" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D119670#3343726</a>>, @erichkeane wrote:<br>
<br>
> In D119670#3343718 <<a href="https://reviews.llvm.org/D119670#3343718" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D119670#3343718</a>>, @rnk wrote:<br>
><br>
>> This broke our libc++ -Werror build:<br>
>><br>
>>   llvm-project/libcxx/src/filesystem/directory_iterator.cpp:107:57: error: unqualified call to std::move [-Werror,-Wunqualified-std-cast-call]<br>
>>                                                   __root_(move(other.__root_)),<br>
>>                                                           ^<br>
>>                                                           std::<br>
>><br>
>> We can disable the warning, but we look forward to an upstream resolution.<br>
><br>
> This is exactly the kind of case that this warning is designed to catch.  Unqualified calls std::move is what we're trying to catch.<br>
<br>
The issue is that for its own tests, libc++ headers are not considered system headers. we should fix libc++. I can do that later today. I though @Quuxplusone did.<br>
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D119670/new/" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D119670/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D119670" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D119670</a><br>
<br>
</blockquote></div>