<div dir="ltr">Hi Martin,<div><br></div><div>I've reverted the patch as 7485e6c7e9c7d484ba1faf2dc53c9b598286455b.  Thank you for reporting the problem!<br></div><div><br></div><div>Kazu Hirata</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jan 10, 2022 at 3:35 AM Martin Storsjö <<a href="mailto:martin@martin.st">martin@martin.st</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Sun, 9 Jan 2022, Kazu Hirata via cfe-commits wrote:<br>
<br>
><br>
> Author: Kazu Hirata<br>
> Date: 2022-01-09T00:19:51-08:00<br>
> New Revision: 80e2c587498a7b2bf14dde47a33a058da6e88a9a<br>
><br>
> URL: <a href="https://github.com/llvm/llvm-project/commit/80e2c587498a7b2bf14dde47a33a058da6e88a9a" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/80e2c587498a7b2bf14dde47a33a058da6e88a9a</a><br>
> DIFF: <a href="https://github.com/llvm/llvm-project/commit/80e2c587498a7b2bf14dde47a33a058da6e88a9a.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/80e2c587498a7b2bf14dde47a33a058da6e88a9a.diff</a><br>
><br>
> LOG: [clang] Remove redundant member initialization (NFC)<br>
><br>
> Identified with readability-redundant-member-init.<br>
<br>
While technically NFC, this causes lots of build warnings (689 warnings) <br>
when built with GCC, like this:<br>
<br>
In file included from <br>
llvm-project/clang/include/clang/Basic/SourceManager.h:37:0,<br>
                  from <br>
llvm-project/clang/lib/Lex/ScratchBuffer.cpp:14:<br>
llvm-project/clang/include/clang/Basic/Diagnostic.h: In <br>
copy constructor ‘clang::DiagnosticBuilder::DiagnosticBuilder(const <br>
clang::DiagnosticBuilder&)’:<br>
llvm-project/clang/include/clang/Basic/Diagnostic.h:1329:3: <br>
warning: base class ‘class clang::StreamingDiagnostic’ should be <br>
explicitly initialized in the copy constructor [-Wextra]<br>
    DiagnosticBuilder(const DiagnosticBuilder &D) {<br>
    ^~~~~~~~~~~~~~~~~<br>
<br>
<br>
With that in mind, I would like to revert this commit - is that ok with <br>
you?<br>
<br>
// Martin<br>
</blockquote></div>