<div dir="ltr">Is there a way to turn this off now, if it's broken for some user/use case? I guess using an -mllvm flag, instead of an -Xclang flag?<br><br>Generally I think for a significant change like this the process would be to add it under a flag, off by default, encourage people to test it by opting in via the flag, eventually change the default for the flag (letting people know they can opt-out using the flag if they see problems & to report them to you so they can be fixed & hopefully they can stop opting out) & then remove the flag when it's stable. Reverting a patch to disable a newly-on-by-default feature is a bit heavyweight and it can be nice to have a flag to control it while it's getting more exposure/experience.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Dec 22, 2021 at 11:31 AM Jeremy Morse via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Jeremy Morse<br>
Date: 2021-12-22T16:30:05Z<br>
New Revision: ea22fdd120aeb1bbb9ea96670d70193dc02b2c5f<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/ea22fdd120aeb1bbb9ea96670d70193dc02b2c5f" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/ea22fdd120aeb1bbb9ea96670d70193dc02b2c5f</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/ea22fdd120aeb1bbb9ea96670d70193dc02b2c5f.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/ea22fdd120aeb1bbb9ea96670d70193dc02b2c5f.diff</a><br>
<br>
LOG: [Clang][DebugInfo] Cease turning instruction-referencing off by default<br>
<br>
Over in D114631 I turned this debug-info feature on by default, for x86_64<br>
only. I'd previously stripped out the clang cc1 option that controlled it<br>
in 651122fc4ac, unfortunately that turned out to not be completely<br>
effective, and the two things deleted in this patch continued to keep it<br>
off-by-default.  Oooff.<br>
<br>
As a follow-up, this patch removes the last few things to do with<br>
ValueTrackingVariableLocations from clang, which was the original purpose<br>
of D114631. In an ideal world, if this patch causes you trouble you'd<br>
revert 3c045070882f instead, which was where this behaviour was supposed<br>
to start being the default, although that might not be practical any more.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    clang/include/clang/Basic/CodeGenOptions.def<br>
    clang/lib/CodeGen/BackendUtil.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/clang/include/clang/Basic/CodeGenOptions.def b/clang/include/clang/Basic/CodeGenOptions.def<br>
index 94b3003a9c33c..723302f108e20 100644<br>
--- a/clang/include/clang/Basic/CodeGenOptions.def<br>
+++ b/clang/include/clang/Basic/CodeGenOptions.def<br>
@@ -368,9 +368,6 @@ ENUM_CODEGENOPT(DebuggerTuning, llvm::DebuggerKind, 3,<br>
 /// emitted.<br>
 VALUE_CODEGENOPT(DwarfVersion, 3, 0)<br>
<br>
-/// Whether to use experimental new variable location tracking.<br>
-CODEGENOPT(ValueTrackingVariableLocations, 1, 0)<br>
-<br>
 /// Whether we should emit CodeView debug information. It's possible to emit<br>
 /// CodeView and DWARF into the same object.<br>
 CODEGENOPT(EmitCodeView, 1, 0)<br>
<br>
diff  --git a/clang/lib/CodeGen/BackendUtil.cpp b/clang/lib/CodeGen/BackendUtil.cpp<br>
index 5e16d3525b383..bacac0a20d4d5 100644<br>
--- a/clang/lib/CodeGen/BackendUtil.cpp<br>
+++ b/clang/lib/CodeGen/BackendUtil.cpp<br>
@@ -603,8 +603,6 @@ static bool initTargetOptions(DiagnosticsEngine &Diags,<br>
   Options.ForceDwarfFrameSection = CodeGenOpts.ForceDwarfFrameSection;<br>
   Options.EmitCallSiteInfo = CodeGenOpts.EmitCallSiteInfo;<br>
   Options.EnableAIXExtendedAltivecABI = CodeGenOpts.EnableAIXExtendedAltivecABI;<br>
-  Options.ValueTrackingVariableLocations =<br>
-      CodeGenOpts.ValueTrackingVariableLocations;<br>
   Options.XRayOmitFunctionIndex = CodeGenOpts.XRayOmitFunctionIndex;<br>
   Options.LoopAlignment = CodeGenOpts.LoopAlignment;<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>