<div dir="ltr">Guess this is untestable right now, since it's overriding with the same value? Maybe worth adding an explicit test for the PS4 default - so that the test would fail /if/ the generic (non-PS4) default was changed (which we'll hopefully change in the near future)?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Nov 30, 2021 at 8:59 AM Paul Robinson via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Paul Robinson<br>
Date: 2021-11-30T08:58:40-08:00<br>
New Revision: b8e03be88dc87303f7401ea7b9906947ac67a6db<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db.diff</a><br>
<br>
LOG: [PS4][DWARF] Explicitly set default DWARF version to 4<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    clang/lib/Driver/ToolChains/PS4CPU.h<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/clang/lib/Driver/ToolChains/PS4CPU.h b/clang/lib/Driver/ToolChains/PS4CPU.h<br>
index 82f9523f84fb8..4bedabaf267c0 100644<br>
--- a/clang/lib/Driver/ToolChains/PS4CPU.h<br>
+++ b/clang/lib/Driver/ToolChains/PS4CPU.h<br>
@@ -80,6 +80,7 @@ class LLVM_LIBRARY_VISIBILITY PS4CPU : public Generic_ELF {<br>
     return LangOptions::SSPStrong;<br>
   }<br>
<br>
+  unsigned GetDefaultDwarfVersion() const override { return 4; }<br>
   llvm::DebuggerKind getDefaultDebuggerTuning() const override {<br>
     return llvm::DebuggerKind::SCE;<br>
   }<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>