<div dir="ltr">Ah, thanks for the details!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 16, 2021 at 1:26 PM Kostya Kortchinsky <<a href="mailto:kostyak@google.com">kostyak@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Apologies.<div>As explained in another thread, this was a mistake of mine as I reverted 2 CLs instead of 1 (mine).</div><div>This was resolved with the original author.</div><div>My own CL ended up breaking some 32-bit builders.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 16, 2021 at 1:22 PM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Please include in the commit message a reason for a revert.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 16, 2021 at 11:14 AM Kostya Kortchinsky via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Kostya Kortchinsky<br>
Date: 2021-08-16T11:13:05-07:00<br>
New Revision: 80ed75e7fb45f9f5fc84ca7cbe258be036015384<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/80ed75e7fb45f9f5fc84ca7cbe258be036015384" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/80ed75e7fb45f9f5fc84ca7cbe258be036015384</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/80ed75e7fb45f9f5fc84ca7cbe258be036015384.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/80ed75e7fb45f9f5fc84ca7cbe258be036015384.diff</a><br>
<br>
LOG: Revert "[NFC] Fix typos"<br>
<br>
This reverts commit b7425e956be60a73004d7ae5bb37da85872c29fb.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp<br>
clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp<br>
compiler-rt/test/profile/Linux/instrprof-cs.c<br>
llvm/include/llvm/Transforms/Instrumentation.h<br>
llvm/lib/ProfileData/SampleProfReader.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp b/clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp<br>
index a13de306eac84..175dfcef0df45 100644<br>
--- a/clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp<br>
+++ b/clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp<br>
@@ -6,7 +6,7 @@<br>
//<br>
//===----------------------------------------------------------------------===//<br>
//<br>
-// This file defines a CheckObjCInstMethSignature, a flow-insensitive check<br>
+// This file defines a CheckObjCInstMethSignature, a flow-insenstive check<br>
// that determines if an Objective-C class interface incorrectly redefines<br>
// the method signature in a subclass.<br>
//<br>
<br>
diff --git a/clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp<br>
index dcca8be55e337..90c5583d89691 100644<br>
--- a/clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp<br>
+++ b/clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp<br>
@@ -6,7 +6,7 @@<br>
//<br>
//===----------------------------------------------------------------------===//<br>
//<br>
-// This file defines a CheckNSError, a flow-insensitive check<br>
+// This file defines a CheckNSError, a flow-insenstive check<br>
// that determines if an Objective-C class interface correctly returns<br>
// a non-void return type.<br>
//<br>
<br>
diff --git a/compiler-rt/test/profile/Linux/instrprof-cs.c b/compiler-rt/test/profile/Linux/instrprof-cs.c<br>
index 0ad6f0350c560..d825525a532db 100644<br>
--- a/compiler-rt/test/profile/Linux/instrprof-cs.c<br>
+++ b/compiler-rt/test/profile/Linux/instrprof-cs.c<br>
@@ -8,7 +8,7 @@<br>
// RUN: %clang_profgen=%t.profraw -o %t.gen.cis -O2 %s<br>
// RUN: %run %t.gen.cis<br>
// RUN: llvm-profdata merge -o %t.cis.profdata %t.profraw<br>
-// Check context insensitive profile<br>
+// Check context insenstive profile<br>
// RUN: %clang_profuse=%t.cis.profdata -O2 -emit-llvm -S %s -o - | FileCheck %s --check-prefix=CIS<br>
int g1 = 1;<br>
int volatile g2 = 2;<br>
<br>
diff --git a/llvm/include/llvm/Transforms/Instrumentation.h b/llvm/include/llvm/Transforms/Instrumentation.h<br>
index 0c822999aecf3..03108bacb0da5 100644<br>
--- a/llvm/include/llvm/Transforms/Instrumentation.h<br>
+++ b/llvm/include/llvm/Transforms/Instrumentation.h<br>
@@ -78,7 +78,7 @@ struct GCOVOptions {<br>
ModulePass *createGCOVProfilerPass(const GCOVOptions &Options =<br>
GCOVOptions::getDefault());<br>
<br>
-// PGO Instrumention. Parameter IsCS indicates if this is the context sensitive<br>
+// PGO Instrumention. Parameter IsCS indicates if this is the context senstive<br>
// instrumentation.<br>
ModulePass *createPGOInstrumentationGenLegacyPass(bool IsCS = false);<br>
ModulePass *<br>
@@ -138,7 +138,7 @@ struct InstrProfOptions {<br>
};<br>
<br>
/// Insert frontend instrumentation based profiling. Parameter IsCS indicates if<br>
-// this is the context sensitive instrumentation.<br>
+// this is the context senstive instrumentation.<br>
ModulePass *createInstrProfilingLegacyPass(<br>
const InstrProfOptions &Options = InstrProfOptions(), bool IsCS = false);<br>
<br>
<br>
diff --git a/llvm/lib/ProfileData/SampleProfReader.cpp b/llvm/lib/ProfileData/SampleProfReader.cpp<br>
index a801ca1ef36d7..6058eddb13dc7 100644<br>
--- a/llvm/lib/ProfileData/SampleProfReader.cpp<br>
+++ b/llvm/lib/ProfileData/SampleProfReader.cpp<br>
@@ -53,7 +53,7 @@ using namespace sampleprof;<br>
// For ext-binary format profiles, the flag is set in the summary.<br>
static cl::opt<bool> ProfileIsFSDisciminator(<br>
"profile-isfs", cl::Hidden, cl::init(false),<br>
- cl::desc("Profile uses flow sensitive discriminators"));<br>
+ cl::desc("Profile uses flow senstive discriminators"));<br>
<br>
/// Dump the function profile for \p FName.<br>
///<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</blockquote></div>
</blockquote></div>