<div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jul 30, 2021 at 12:59 PM <<a href="mailto:paul.robinson@sony.com" target="_blank">paul.robinson@sony.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">





<div lang="EN-US">
<div>
<p class="MsoNormal">Do you have a suggestion for how to fix it?  This isn’t actually my test, I tripped over it and it seemed like it would be easy to get it to work. 
<span style="font-family:"Segoe UI Emoji",sans-serif">☹</span><u></u><u></u></p>
</div></div></blockquote><div><br></div><div>I think removing all of the `-target` options might help. Alternatively, I don't see why the test should actually call out to the assembler (could just check the driver would invoke it with the options of interest).</div><div><br></div><div>If the test is also meant to check that an error from the native assembler produces an error return code from the driver, then that could be tested using an ersatz assembler picked up using `-B` (but I would hope that there's a different test to cover that already).</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="EN-US"><div><p class="MsoNormal">Thanks,<u></u><u></u></p>
<p class="MsoNormal">--paulr<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border-color:currentcolor currentcolor currentcolor blue;border-style:none none none solid;border-width:medium medium medium 1.5pt;padding:0in 0in 0in 4pt">
<div>
<div style="border-color:rgb(225,225,225) currentcolor currentcolor;border-style:solid none none;border-width:1pt medium medium;padding:3pt 0in 0in">
<p class="MsoNormal"><b>From:</b> Hubert Tong <<a href="mailto:hubert.reinterpretcast@gmail.com" target="_blank">hubert.reinterpretcast@gmail.com</a>> <br>
<b>Sent:</b> Friday, July 30, 2021 12:43 PM<br>
<b>To:</b> Robinson, Paul <<a href="mailto:paul.robinson@sony.com" target="_blank">paul.robinson@sony.com</a>>; Paul Robinson <<a href="mailto:llvmlistbot@llvm.org" target="_blank">llvmlistbot@llvm.org</a>><br>
<b>Cc:</b> cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>><br>
<b>Subject:</b> Re: [clang] 9ca905b - XFAIL a test on ppc64<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<div>
<p class="MsoNormal">On Fri, Jul 30, 2021 at 12:05 PM Paul Robinson via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-color:currentcolor currentcolor currentcolor rgb(204,204,204);border-style:none none none solid;border-width:medium medium medium 1pt;padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><br>
Author: Paul Robinson<br>
Date: 2021-07-30T09:05:14-07:00<br>
New Revision: 9ca905b52d53c46aceb4d28e44dfbf4a815d0c68<br>
<br>
URL: <a href="https://urldefense.com/v3/__https:/github.com/llvm/llvm-project/commit/9ca905b52d53c46aceb4d28e44dfbf4a815d0c68__;!!JmoZiZGBv3RvKRSx!v4BWRPD6Co0A_0iVezXCtxoroTbBRK8XfnUbtx43IGKDafGio87LV_HvS_y3xwuhfg$" target="_blank">
https://github.com/llvm/llvm-project/commit/9ca905b52d53c46aceb4d28e44dfbf4a815d0c68</a><br>
DIFF: <a href="https://urldefense.com/v3/__https:/github.com/llvm/llvm-project/commit/9ca905b52d53c46aceb4d28e44dfbf4a815d0c68.diff__;!!JmoZiZGBv3RvKRSx!v4BWRPD6Co0A_0iVezXCtxoroTbBRK8XfnUbtx43IGKDafGio87LV_HvS_xqgmn2aA$" target="_blank">
https://github.com/llvm/llvm-project/commit/9ca905b52d53c46aceb4d28e44dfbf4a815d0c68.diff</a><br>
<br>
LOG: XFAIL a test on ppc64<br>
<br>
Buildbot failure:<br>
<a href="https://urldefense.com/v3/__https:/lab.llvm.org/buildbot/*/builders/105/builds/13141__;Iw!!JmoZiZGBv3RvKRSx!v4BWRPD6Co0A_0iVezXCtxoroTbBRK8XfnUbtx43IGKDafGio87LV_HvS_xATeKedQ$" target="_blank">https://lab.llvm.org/buildbot/#/builders/105/builds/13141</a><br>
which provides no details about why it failed,<u></u><u></u></p>
</blockquote>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Which would be because the test is set up to display warnings but won't display errors.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">/usr/bin/as: unrecognized option '--32'<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I also tried `x86_64-pc-linux-gnu`:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">/usr/bin/as: unrecognized option '--64'<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">It probably makes sense that these options aren't supported if the system is 64-bit only.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border-color:currentcolor currentcolor currentcolor rgb(204,204,204);border-style:none none none solid;border-width:medium medium medium 1pt;padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">but the only failure<br>
reports are for ppc64 bots.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    clang/test/Driver/as-no-warnings.c<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/clang/test/Driver/as-no-warnings.c b/clang/test/Driver/as-no-warnings.c<br>
index 9c2b3f096872..77971389ee65 100644<br>
--- a/clang/test/Driver/as-no-warnings.c<br>
+++ b/clang/test/Driver/as-no-warnings.c<br>
@@ -14,6 +14,7 @@<br>
 // REQUIRES: clang-driver<br>
 // REQUIRES: x86-registered-target<br>
 // REQUIRES: system-linux<br>
+// XFAIL: ppc64<br>
<br>
 // CHECK: "-cc1" {{.*}} "-massembler-no-warn"<br>
 // CHECK-NOIAS: "--no-warn"<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://urldefense.com/v3/__https:/lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits__;!!JmoZiZGBv3RvKRSx!v4BWRPD6Co0A_0iVezXCtxoroTbBRK8XfnUbtx43IGKDafGio87LV_HvS_wLZC7qfQ$" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</div>
</div>

</blockquote></div></div>