<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:times new roman,serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 14, 2021 at 4:04 PM Xinliang David Li <<a href="mailto:davidxl@google.com">davidxl@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div style="font-family:monospace;font-size:small;color:rgb(0,0,0)"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 14, 2021 at 3:59 PM Roman Lebedev via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">lebedev.ri added a subscriber: MaskRay.<br>
lebedev.ri added a comment.<br>
<br>
In D104099#2815531 <<a href="https://reviews.llvm.org/D104099#2815531" rel="noreferrer" target="_blank">https://reviews.llvm.org/D104099#2815531</a>>, @wenlei wrote:<br>
<br>
> In D104099#2814167 <<a href="https://reviews.llvm.org/D104099#2814167" rel="noreferrer" target="_blank">https://reviews.llvm.org/D104099#2814167</a>>, @davidxl wrote:<br>
><br>
>> Adding Wei to help measure performance impact on our internal workloads.  Also add Wenlei to help measure impact with FB's workloads.<br>
><br>
> Measured perf using FB internal workload w/ and w/o this pass, result is neutral.<br>
<br>
Thank you for checking!<br>
<br>
So far, it seems the reaction to this proposal has been overwhelmingly positive.<br>
Does anyone else wish to chime in? Should i land this? @asbirlea @MaskRay ?<br></blockquote><div><br></div><div style="font-family:monospace;font-size:small;color:rgb(0,0,0)">Wei is doing more measurement @google. Please wait for the response.</div><div style="font-family:monospace;font-size:small;color:rgb(0,0,0)"><br></div><div style="font-family:monospace;font-size:small;color:rgb(0,0,0)">David</div></div></div></blockquote><div><br></div><div><div class="gmail_default" style="font-family:"times new roman",serif">Start doing the test. Will report back. </div><div class="gmail_default" style="font-family:"times new roman",serif"><br></div><div class="gmail_default" style="font-family:"times new roman",serif">Wei.</div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div style="font-family:monospace;font-size:small;color:rgb(0,0,0)"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D104099/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D104099/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D104099" rel="noreferrer" target="_blank">https://reviews.llvm.org/D104099</a><br>
<br>
</blockquote></div></div>
</blockquote></div></div>