<div dir="ltr"><div>Hi,</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Mar 30, 2021 at 7:52 PM David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr">Is there a more reliable remark that could be tested for? (Clang shouldn't be testing all remarks - just that the remark infrastructure in general is wired up (specific remarks should be tested in llvm) - so picking some really stable remark would be great)<br><br>maybe there's a remark for "this always_inline thing can't be inlined because it's recursive" for instance?</div><br></blockquote><div><br></div><div>That's a great point, there certainly are more stable remarks, e.g. inlining as you suggested or GVN. I can add a separate test for that, so we can still keep testing the vectorization remark. WDYT?</div><div><br></div><div>Cheers,</div><div>Florian</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Mar 29, 2021 at 9:29 AM Florian Hahn via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><br>
Author: Florian Hahn<br>
Date: 2021-03-29T17:27:01+01:00<br>
New Revision: 9320ac9b4965d769632398b620ca3e4af9b56b12<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/9320ac9b4965d769632398b620ca3e4af9b56b12" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/9320ac9b4965d769632398b620ca3e4af9b56b12</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/9320ac9b4965d769632398b620ca3e4af9b56b12.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/9320ac9b4965d769632398b620ca3e4af9b56b12.diff</a><br>
<br>
LOG: [Clang] Only run test when X86 backend is built.<br>
<br>
After c773d0f97304 the remark is only emitted if the loop is profitable<br>
to vectorize, but cannot be vectorized. Hence, it depends on<br>
X86-specific cost-modeling.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    clang/test/Frontend/optimization-remark-options.c<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/clang/test/Frontend/optimization-remark-options.c b/clang/test/Frontend/optimization-remark-options.c<br>
index 38dbbfbaccec0..f222eff37a5ef 100644<br>
--- a/clang/test/Frontend/optimization-remark-options.c<br>
+++ b/clang/test/Frontend/optimization-remark-options.c<br>
@@ -1,3 +1,4 @@<br>
+// REQUIRES: x86-registered-target<br>
 // RUN: %clang -O1 -fvectorize -target x86_64-unknown-unknown -Rpass-analysis=loop-vectorize -emit-llvm -S %s -o - 2>&1 | FileCheck %s<br>
<br>
 // CHECK: {{.*}}:9:11: remark: loop not vectorized: cannot prove it is safe to reorder floating-point operations; allow reordering by specifying '#pragma clang loop vectorize(enable)' before the loop or by providing the compiler option '-ffast-math'.<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><br><a href="http://www.fhahn.com/" target="_blank">http://www.fhahn.com/</a><br></div></div>