<div dir="ltr">Is this missing a test case?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Mar 16, 2021 at 4:47 PM Stephen Kelly via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Stephen Kelly<br>
Date: 2021-03-16T23:46:31Z<br>
New Revision: a00d44012820e9ed2eba623dd61ca9cf5a2ce115<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/a00d44012820e9ed2eba623dd61ca9cf5a2ce115" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/a00d44012820e9ed2eba623dd61ca9cf5a2ce115</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/a00d44012820e9ed2eba623dd61ca9cf5a2ce115.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/a00d44012820e9ed2eba623dd61ca9cf5a2ce115.diff</a><br>
<br>
LOG: [AST] Hide errors from the attempt to introspect nodes<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    clang/lib/Tooling/DumpTool/ClangSrcLocDump.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/clang/lib/Tooling/DumpTool/ClangSrcLocDump.cpp b/clang/lib/Tooling/DumpTool/ClangSrcLocDump.cpp<br>
index 6615f865221d..74ba70eefa04 100644<br>
--- a/clang/lib/Tooling/DumpTool/ClangSrcLocDump.cpp<br>
+++ b/clang/lib/Tooling/DumpTool/ClangSrcLocDump.cpp<br>
@@ -92,7 +92,13 @@ int main(int argc, const char **argv) {<br>
   auto ParsedArgs = Opts.ParseArgs(llvm::makeArrayRef(Argv).slice(1),<br>
                                    MissingArgIndex, MissingArgCount);<br>
   ParseDiagnosticArgs(*DiagOpts, ParsedArgs);<br>
-  TextDiagnosticPrinter DiagnosticPrinter(llvm::errs(), &*DiagOpts);<br>
+<br>
+  // Don't output diagnostics, because common scenarios such as<br>
+  // cross-compiling fail with diagnostics.  This is not fatal, but<br>
+  // just causes attempts to use the introspection API to return no data.<br>
+  std::string Str;<br>
+  llvm::raw_string_ostream OS(Str);<br>
+  TextDiagnosticPrinter DiagnosticPrinter(OS, &*DiagOpts);<br>
   DiagnosticsEngine Diagnostics(<br>
       IntrusiveRefCntPtr<DiagnosticIDs>(new DiagnosticIDs()), &*DiagOpts,<br>
       &DiagnosticPrinter, false);<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>