<div dir="auto"><div>Yeah. I don't actually know those details, the phab revision referenced (should have been a URL, oops) is all I know.<div dir="auto"><br></div><div dir="auto">The new version with the qualifier is better than the old one in any case though, so no need to ever remove it.</div><div dir="auto">(At least, we try to always spell the llvm qualifiers in clangd)</div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Dec 22, 2020, 2:26 AM David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Would be handy to include a comment to document which compiler version, etc - so we know when we can remove this/don't waste time trying to remove it too soon.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Dec 17, 2020 at 3:51 AM Sam McCall via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" rel="noreferrer">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Sam McCall<br>
Date: 2020-12-17T12:51:12+01:00<br>
New Revision: 894c4761c67ac850e156a26aa427035a811d7aed<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/894c4761c67ac850e156a26aa427035a811d7aed" rel="noreferrer noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/894c4761c67ac850e156a26aa427035a811d7aed</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/894c4761c67ac850e156a26aa427035a811d7aed.diff" rel="noreferrer noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/894c4761c67ac850e156a26aa427035a811d7aed.diff</a><br>
<br>
LOG: [clangd] Add llvm:: qualifier to work around GCC bug. NFC<br>
<br>
Some old GCC versions seem to miss the default template parameter when<br>
using the clang/Basic/LLVM.h forward declarations of SmallVector.<br>
<br>
See D92788<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    clang-tools-extra/clangd/Headers.h<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/clang-tools-extra/clangd/Headers.h b/clang-tools-extra/clangd/Headers.h<br>
index d86a4788f0a6..fd9db5562813 100644<br>
--- a/clang-tools-extra/clangd/Headers.h<br>
+++ b/clang-tools-extra/clangd/Headers.h<br>
@@ -136,7 +136,7 @@ class IncludeStructure {<br>
   unsigned fileIndex(llvm::StringRef Name);<br>
   llvm::StringMap<unsigned> NameToIndex; // Values are file indexes.<br>
   // Maps a file's index to that of the files it includes.<br>
-  llvm::DenseMap<unsigned, SmallVector<unsigned>> IncludeChildren;<br>
+  llvm::DenseMap<unsigned, llvm::SmallVector<unsigned>> IncludeChildren;<br>
 };<br>
<br>
 /// Returns a PPCallback that visits all inclusions in the main file.<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" rel="noreferrer">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</blockquote></div></div></div>