<div dir="ltr">Thanks for fixing the tests, but didn't the tests point out a true regression in clang-query functionality here?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Nov 23, 2020 at 10:23 AM Stephen Kelly via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Stephen Kelly<br>
Date: 2020-11-23T15:23:13Z<br>
New Revision: 76bd4444e36197465f1c72f4b6f1d59721012a59<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/76bd4444e36197465f1c72f4b6f1d59721012a59" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/76bd4444e36197465f1c72f4b6f1d59721012a59</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/76bd4444e36197465f1c72f4b6f1d59721012a59.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/76bd4444e36197465f1c72f4b6f1d59721012a59.diff</a><br>
<br>
LOG: Fix tests for clang-query completion<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    clang-tools-extra/unittests/clang-query/QueryParserTest.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/clang-tools-extra/unittests/clang-query/QueryParserTest.cpp b/clang-tools-extra/unittests/clang-query/QueryParserTest.cpp<br>
index 4a0a80146af4..78d6f593777d 100644<br>
--- a/clang-tools-extra/unittests/clang-query/QueryParserTest.cpp<br>
+++ b/clang-tools-extra/unittests/clang-query/QueryParserTest.cpp<br>
@@ -232,14 +232,12 @@ TEST_F(QueryParserTest, Complete) {<br>
   EXPECT_EQ("dump", Comps[3].DisplayText);<br>
<br>
   Comps = QueryParser::complete("set traversal ", 14, QS);<br>
-  ASSERT_EQ(3u, Comps.size());<br>
+  ASSERT_EQ(2u, Comps.size());<br>
<br>
   EXPECT_EQ("AsIs ", Comps[0].TypedText);<br>
   EXPECT_EQ("AsIs", Comps[0].DisplayText);<br>
-  EXPECT_EQ("IgnoreImplicitCastsAndParentheses ", Comps[1].TypedText);<br>
-  EXPECT_EQ("IgnoreImplicitCastsAndParentheses", Comps[1].DisplayText);<br>
-  EXPECT_EQ("IgnoreUnlessSpelledInSource ", Comps[2].TypedText);<br>
-  EXPECT_EQ("IgnoreUnlessSpelledInSource", Comps[2].DisplayText);<br>
+  EXPECT_EQ("IgnoreUnlessSpelledInSource ", Comps[1].TypedText);<br>
+  EXPECT_EQ("IgnoreUnlessSpelledInSource", Comps[1].DisplayText);<br>
<br>
   Comps = QueryParser::complete("match while", 11, QS);<br>
   ASSERT_EQ(1u, Comps.size());<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>