<div dir="ltr"><div dir="ltr"></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 17 Sep 2020 at 18:00, Vitaly Buka via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">vitalybuka committed rG03358becbf22: [NFC][Lsan] Fix zero-sized array compilation error (authored by vitalybuka).<br>
<br>
[NFC][Lsan] Fix zero-sized array compilation error<br>
<br>
<br>
BRANCHES<br>
  master<br>
<br>
Files:<br>
  /clang/lib/Tooling/Syntax/Synthesis.cpp<br>
  /compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cpp<br>
<br>
PATCH<br>
<br>
diff --git a/clang/lib/Tooling/Syntax/Synthesis.cpp b/clang/lib/Tooling/Syntax/Synthesis.cpp<br>
index 2fe95a40cb32..ea2739523a09 100644<br>
--- a/clang/lib/Tooling/Syntax/Synthesis.cpp<br>
+++ b/clang/lib/Tooling/Syntax/Synthesis.cpp<br>
@@ -58,6 +58,7 @@ syntax::Tree *allocateTree(syntax::Arena &A, syntax::NodeKind Kind) {<br>
   switch (Kind) {<br>
   case syntax::NodeKind::Leaf:<br>
     assert(false);<br>
+    break; <br></blockquote><div><br></div><div>I accidentally committed my local fix for the fall through warning. Please confirm that this is an acceptable fix.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
   case syntax::NodeKind::TranslationUnit:<br>
     return new (A.getAllocator()) syntax::TranslationUnit;<br>
   case syntax::NodeKind::UnknownExpression:<br>
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cpp<br>
index cf21ab854007..1e71d6512c1f 100644<br>
--- a/compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cpp<br>
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cpp<br>
@@ -504,13 +504,13 @@ typedef struct user regs_struct;<br>
 #elif defined(__aarch64__)<br>
 typedef struct user_pt_regs regs_struct;<br>
 #define REG_SP sp<br>
-static constexpr uptr kExtraRegs[] = {};<br>
+static constexpr uptr kExtraRegs[] = {0};<br>
 #define ARCH_IOVEC_FOR_GETREGSET<br>
<br>
 #elif defined(__s390__)<br>
 typedef _user_regs_struct regs_struct;<br>
 #define REG_SP gprs[15]<br>
-static constexpr uptr kExtraRegs[] = {};<br>
+static constexpr uptr kExtraRegs[] = {0};<br>
 #define ARCH_IOVEC_FOR_GETREGSET<br>
<br>
 #else<br>
@@ -578,7 +578,7 @@ PtraceRegistersStatus SuspendedThreadsListLinux::GetRegistersAndSP(<br>
   if (!fail) {<br>
     // Accept the first available and do not report errors.<br>
     for (uptr regs : kExtraRegs)<br>
-      if (append(regs))<br>
+      if (regs && append(regs))<br>
         break;<br>
   }<br>
 #else<br>
<br>
Users:<br>
  vitalybuka (Author)<br>
<br>
<a href="https://reviews.llvm.org/rG03358becbf22" rel="noreferrer" target="_blank" class="cremed">https://reviews.llvm.org/rG03358becbf22</a><br>
<br>
</blockquote></div></div>