<div dir="auto">Yup, unless you this breaks something, I'd really prefer to keep it.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, 12 Sep 2020, 03:24 David Blaikie, <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">LLVM_DUMP_METHOD is meant to be used for annotating functions that might be useful to execute from a debugger to dump data structures, etc - so it's expected that they'd be unused. Do you find that this function is not useful to use from a debugger/similar situation? (or perhaps because the function was "static" it was hitting a compiler warning/error & not actually being emitted into the resulting binary for use by an interactive debugger?)<br><br>+Kristof for comments/thoughts<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Sep 11, 2020 at 4:50 PM Vitaly Buka via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" rel="noreferrer">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Vitaly Buka<br>
Date: 2020-09-11T16:50:30-07:00<br>
New Revision: a8503b87f739776cc9d5738f69aa0990db952340<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/a8503b87f739776cc9d5738f69aa0990db952340" rel="noreferrer noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/a8503b87f739776cc9d5738f69aa0990db952340</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/a8503b87f739776cc9d5738f69aa0990db952340.diff" rel="noreferrer noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/a8503b87f739776cc9d5738f69aa0990db952340.diff</a><br>
<br>
LOG: [NFC] Remove unused static function<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp b/clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp<br>
index 441dcad42444..ce4addd2f945 100644<br>
--- a/clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp<br>
+++ b/clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp<br>
@@ -834,11 +834,6 @@ LLVM_DUMP_METHOD static void dumpArgTokensToStream(llvm::raw_ostream &Out,<br>
const Preprocessor &PP,<br>
const ArgTokensTy &Toks);<br>
<br>
-LLVM_DUMP_METHOD static void dumpArgTokens(const Preprocessor &PP,<br>
- const ArgTokensTy &Toks) {<br>
- dumpArgTokensToStream(llvm::errs(), PP, Toks);<br>
-}<br>
-<br>
namespace {<br>
/// Maps unexpanded macro parameters to expanded arguments. A macro argument may<br>
/// need to expanded further when it is nested inside another macro.<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" rel="noreferrer">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</blockquote></div>