<div dir="ltr">Usually this would be addressed with a "using Base::Function" - makes it clear you aren't intending to override any base behavior, just want to continue to expose the full overload set</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 24, 2020 at 8:11 AM Raphael Isemann via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Raphael Isemann<br>
Date: 2020-08-24T17:10:55+02:00<br>
New Revision: c9b45ce1fd97531c228e092bedee719b971f82a3<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/c9b45ce1fd97531c228e092bedee719b971f82a3" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/c9b45ce1fd97531c228e092bedee719b971f82a3</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/c9b45ce1fd97531c228e092bedee719b971f82a3.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/c9b45ce1fd97531c228e092bedee719b971f82a3.diff</a><br>
<br>
LOG: [clang][NFC] Fix a GCC warning in ASTImporterTest.cpp<br>
<br>
Apparently only overriding one of the two CompleteType overloads causes<br>
GCC to emit a warning with -Woverloaded-virtual .<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    clang/unittests/AST/ASTImporterTest.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/clang/unittests/AST/ASTImporterTest.cpp b/clang/unittests/AST/ASTImporterTest.cpp<br>
index 9cab6cca0dc4..ecddd4d43752 100644<br>
--- a/clang/unittests/AST/ASTImporterTest.cpp<br>
+++ b/clang/unittests/AST/ASTImporterTest.cpp<br>
@@ -5803,6 +5803,7 @@ struct SourceWithCompletedTagList : clang::ExternalASTSource {<br>
     Record->completeDefinition();<br>
     CompletedTags.push_back(Tag);<br>
   }<br>
+  void CompleteType(ObjCInterfaceDecl *) override {}<br>
 };<br>
<br>
 TEST_P(ImportWithExternalSource, CompleteRecordBeforeImporting) {<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>