<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Aug 5, 2020 at 8:30 AM Hans Wennborg via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">hans added a comment.<br>
<br>
In D84782#2191429 <<a href="https://reviews.llvm.org/D84782#2191429" rel="noreferrer" target="_blank">https://reviews.llvm.org/D84782#2191429</a>>, @yamauchi wrote:<br>
<br>
> In D84782#2191243 <<a href="https://reviews.llvm.org/D84782#2191243" rel="noreferrer" target="_blank">https://reviews.llvm.org/D84782#2191243</a>>, @MaskRay wrote:<br>
><br>
>> @yamauchi Do we need cd890944ad344b1b8cac58332ab11c9eec6b61e9 <<a href="https://reviews.llvm.org/rGcd890944ad344b1b8cac58332ab11c9eec6b61e9" rel="noreferrer" target="_blank">https://reviews.llvm.org/rGcd890944ad344b1b8cac58332ab11c9eec6b61e9</a>> and 3d6f53018f845e893ad34f64ff2851a2e5c3ba1d <<a href="https://reviews.llvm.org/rG3d6f53018f845e893ad34f64ff2851a2e5c3ba1d" rel="noreferrer" target="_blank">https://reviews.llvm.org/rG3d6f53018f845e893ad34f64ff2851a2e5c3ba1d</a>> in <a href="https://github.com/llvm/llvm-project/tree/release/11.x" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/tree/release/11.x</a> ?<br>
><br>
> I think it'd be good to have them, if possible, though it's a latent, non-recent bug.<br>
<br>
They're hard to apply without 50da55a58534e9207d8d5e31c8b4b5cf0c624175 <<a href="https://reviews.llvm.org/rG50da55a58534e9207d8d5e31c8b4b5cf0c624175" rel="noreferrer" target="_blank">https://reviews.llvm.org/rG50da55a58534e9207d8d5e31c8b4b5cf0c624175</a>>. Do you think we should take that also? Or maybe this can wait since it's not a new bug.<br></blockquote><div><br></div><div>50da55a58534e9207d8d5e31c8b4b5cf0c624175<span class="gmail_default" style="font-family:arial,helvetica,sans-serif"> isn't a bug fix but it's not changing the default behavior. So, it is probably safe to take it. That said, </span><span style="font-family:arial,helvetica,sans-serif">I'd say this can wait unless there's some immediate issue<span class="gmail_default" style="font-family:arial,helvetica,sans-serif">, since it's not a new bug.</span></span></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D84782/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D84782/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D84782" rel="noreferrer" target="_blank">https://reviews.llvm.org/D84782</a><br>
<br>
</blockquote></div></div>