<div dir="ltr">Uh, you're right, thank you for the fix! I wonder why that was building for me...<div><br></div><div>Again, thank you for noticing!</div><div><br></div><div>Kirill</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 27, 2020 at 2:41 PM Hans Wennborg via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">hans added inline comments.<br>
<br>
<br>
================<br>
Comment at: clang-tools-extra/clangd/<a href="http://Features.inc.in:2" rel="noreferrer" target="_blank">Features.inc.in:2</a><br>
#define CLANGD_BUILD_XPC @CLANGD_BUILD_XPC@<br>
+#define CLANGD_ENABLE_REMOTE @CLANGD_ENABLE_REMTE@<br>
----------------<br>
I'm guessing this should be @CLANGD_ENABLE_REMOTE@<br>
The gn build was upset: <a href="http://45.33.8.238/linux/23942/step_4.txt" rel="noreferrer" target="_blank">http://45.33.8.238/linux/23942/step_4.txt</a><br>
Speculatively fixed in 47a0254229ca425aa4e169c2db14e92b8db86784. Please shout if this was wrong.<br>
<br>
<br>
Repository:<br>
rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D83817/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D83817/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D83817" rel="noreferrer" target="_blank">https://reviews.llvm.org/D83817</a><br>
<br>
<br>
<br>
</blockquote></div>