<div dir="auto"><div>Seems like we should disable the warning for this compiler instead of making the code worse for the benefit of a temporarily broken warning?<br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Jul 4, 2020, 8:42 PM Nico Weber via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Author: Nico Weber<br>
Date: 2020-07-04T20:41:33-04:00<br>
New Revision: 7e2d27bc554eb607c90e55c89d2537f5d711234c<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/7e2d27bc554eb607c90e55c89d2537f5d711234c" rel="noreferrer noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/7e2d27bc554eb607c90e55c89d2537f5d711234c</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/7e2d27bc554eb607c90e55c89d2537f5d711234c.diff" rel="noreferrer noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/7e2d27bc554eb607c90e55c89d2537f5d711234c.diff</a><br>
<br>
LOG: Fix two -Wrange-loop-analysis warnings that Xcode 12 beta incorrectly complains about<br>
<br>
Xcode 12 beta apparently has the Wrange-loop-analysis changes from<br>
half a year ago, but it seems to lack <a href="https://reviews.llvm.org/D72212" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D72212</a><br>
which made the warning usable again.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    clang-tools-extra/clangd/XRefs.cpp<br>
    clang-tools-extra/clangd/unittests/PreambleTests.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/clang-tools-extra/clangd/XRefs.cpp b/clang-tools-extra/clangd/XRefs.cpp<br>
index 9b44edce95da..c208e953f2ab 100644<br>
--- a/clang-tools-extra/clangd/XRefs.cpp<br>
+++ b/clang-tools-extra/clangd/XRefs.cpp<br>
@@ -1049,7 +1049,7 @@ ReferencesResult findReferences(ParsedAST &AST, Position Pos, uint32_t Limit,<br>
       const auto &IDToRefs = AST.getMacros().MacroRefs;<br>
       auto Refs = IDToRefs.find(*MacroSID);<br>
       if (Refs != IDToRefs.end()) {<br>
-        for (const auto Ref : Refs->second) {<br>
+        for (const auto &Ref : Refs->second) {<br>
           Location Result;<br>
           Result.range = Ref;<br>
           Result.uri = URIMainFile;<br>
<br>
diff  --git a/clang-tools-extra/clangd/unittests/PreambleTests.cpp b/clang-tools-extra/clangd/unittests/PreambleTests.cpp<br>
index 5bbcb292610e..8c9669a945dd 100644<br>
--- a/clang-tools-extra/clangd/unittests/PreambleTests.cpp<br>
+++ b/clang-tools-extra/clangd/unittests/PreambleTests.cpp<br>
@@ -125,7 +125,7 @@ TEST(PreamblePatchTest, IncludeParsing) {<br>
         #/**/include <b.h>)cpp",<br>
   };<br>
<br>
-  for (const auto Case : Cases) {<br>
+  for (const auto &Case : Cases) {<br>
     Annotations Test(Case);<br>
     const auto Code = Test.code();<br>
     SCOPED_TRACE(Code);<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" rel="noreferrer">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div></div>