<div dir="ltr"><div dir="ltr">On Thu, May 28, 2020 at 5:17 PM Gallop, Russell <<a href="mailto:Russell.Gallop@sony.com">Russell.Gallop@sony.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-GB">
<div class="gmail-m_-2769019629955482188WordSection1">
<p class="MsoNormal"><span>Hi Sam,<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>Thanks for looking at this. You could use something like in clang/</span>
<span>./unittests/Tooling/RecursiveASTVisitorTests/LambdaExpr.cpp:<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span> if (llvm::Triple(llvm::sys::getDefaultTargetTriple()).isPS4())<u></u><u></u></span></p>
<p class="MsoNormal"><span> return; // PS4 does not support fastcall.</span></p></div></div></blockquote><div>Thanks - we'd really like to disable testing rather than make the tests spuriously pass though.</div><div>This test failure does reflect a clangd that doesn't work properly: it should always be able to parse "throw" statements unless explicitly directed otherwise.</div><div>However it doesn't really make sense to run clangd on a PS4 so this isn't a bug we're likely to fix.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="EN-GB"><div class="gmail-m_-2769019629955482188WordSection1"><p class="MsoNormal"><span><u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>Regards<u></u><u></u></span></p>
<p class="MsoNormal"><span>Russ<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Sam McCall <<a href="mailto:sammccall@google.com" target="_blank">sammccall@google.com</a>>
<br>
<b>Sent:</b> 28 May 2020 15:55<br>
<b>To:</b> <a href="mailto:reviews%2BD78454%2Bpublic%2Bf260770db3c2915f@reviews.llvm.org" target="_blank">reviews+D78454+public+f260770db3c2915f@reviews.llvm.org</a><br>
<b>Cc:</b> Adam Czachorowski <<a href="mailto:adamcz@google.com" target="_blank">adamcz@google.com</a>>; Gallop, Russell <<a href="mailto:Russell.Gallop@sony.com" target="_blank">Russell.Gallop@sony.com</a>>; Ilya Biryukov <<a href="mailto:iu.biryukov@gmail.com" target="_blank">iu.biryukov@gmail.com</a>>; Fangrui Song <<a href="mailto:maskray@google.com" target="_blank">maskray@google.com</a>>; Jan Korous <<a href="mailto:jkorous@apple.com" target="_blank">jkorous@apple.com</a>>; <a href="mailto:mgrang.1234@gmail.com" target="_blank">mgrang.1234@gmail.com</a>; Alex L <<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>>; Kadir
Çetinkaya <<a href="mailto:kadircet@google.com" target="_blank">kadircet@google.com</a>>; Utkarsh Saxena <<a href="mailto:usx@google.com" target="_blank">usx@google.com</a>>; cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>>; Theko Lekena <<a href="mailto:mlekena@skidmore.edu" target="_blank">mlekena@skidmore.edu</a>>; Nicolas Lesser <<a href="mailto:blitzrakete@gmail.com" target="_blank">blitzrakete@gmail.com</a>>; Han Shen <<a href="mailto:shenhan@google.com" target="_blank">shenhan@google.com</a>>; Haojian Wu <<a href="mailto:hokein@google.com" target="_blank">hokein@google.com</a>><br>
<b>Subject:</b> Re: [PATCH] D78454: [clangd] Highlight related control flow.<u></u><u></u></span></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Thu, May 28, 2020 at 4:35 PM Russell Gallop via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal">russell.gallop added a comment.<br>
<br>
Hi Sam,<br>
<br>
It looks like this is causing a failure on the Windows PS4 buildbot: <a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/32606" target="_blank">
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/32606</a><br>
<br>
Please could you take a look? PS4 target disables RTTI, hence exceptions, by default so it is probably related to that.<u></u><u></u></p>
</blockquote>
<div>
<p class="MsoNormal">Thanks!<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Hmm, the clangd tests are supposed to be disabled on PS4 for exactly these sorts of reasons. It looks like that's only working for shell tests, not gtests though.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Lit config is a tangled mess... is there an #ifdef we can use to disable just that test on PS4 until I get this sorted out?<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal" style="margin-bottom:12pt"><br>
Thanks<br>
Russ<br>
<br>
<br>
Repository:<br>
rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D78454/new/" target="_blank">https://reviews.llvm.org/D78454/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D78454" target="_blank">https://reviews.llvm.org/D78454</a><br>
<br>
<br>
<u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
<u></u><br>
<br>
<div class="gmail-m_-2769019629955482188WordSection1">
<p class="MsoNormal"><span><br>
********************************************************************** <br>
This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify
</span><a href="mailto:siee.postmaster@sony.com" target="_blank"><span>siee.postmaster@sony.com</span></a><span><br>
This footnote also confirms that this email message has been checked for all known viruses.<br>
Sony Interactive Entertainment Europe Limited<br>
Registered Office: 10 Great Marlborough Street, London W1F 7LP, United Kingdom<br>
Registered in England: 3277793<br>
**********************************************************************<br>
</span><span style="font-size:18pt;font-family:Webdings;color:green"><br>
P</span><b><i><span> Please consider the environment before printing this e-mail</span></i></b>
</p>
</div>
</div>
</blockquote></div></div>