<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Hi Sam,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Thanks for looking at this. You could use something like in clang/</span>
<span style="mso-fareast-language:EN-US">./unittests/Tooling/RecursiveASTVisitorTests/LambdaExpr.cpp:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"> if (llvm::Triple(llvm::sys::getDefaultTargetTriple()).isPS4())<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"> return; // PS4 does not support fastcall.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Regards<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Russ<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Sam McCall <sammccall@google.com>
<br>
<b>Sent:</b> 28 May 2020 15:55<br>
<b>To:</b> reviews+D78454+public+f260770db3c2915f@reviews.llvm.org<br>
<b>Cc:</b> Adam Czachorowski <adamcz@google.com>; Gallop, Russell <Russell.Gallop@sony.com>; Ilya Biryukov <iu.biryukov@gmail.com>; Fangrui Song <maskray@google.com>; Jan Korous <jkorous@apple.com>; mgrang.1234@gmail.com; Alex L <arphaman@gmail.com>; Kadir
Çetinkaya <kadircet@google.com>; Utkarsh Saxena <usx@google.com>; cfe-commits <cfe-commits@lists.llvm.org>; Theko Lekena <mlekena@skidmore.edu>; Nicolas Lesser <blitzrakete@gmail.com>; Han Shen <shenhan@google.com>; Haojian Wu <hokein@google.com><br>
<b>Subject:</b> Re: [PATCH] D78454: [clangd] Highlight related control flow.<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Thu, May 28, 2020 at 4:35 PM Russell Gallop via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<o:p></o:p></p>
</div>
<div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal">russell.gallop added a comment.<br>
<br>
Hi Sam,<br>
<br>
It looks like this is causing a failure on the Windows PS4 buildbot: <a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/32606" target="_blank">
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/32606</a><br>
<br>
Please could you take a look? PS4 target disables RTTI, hence exceptions, by default so it is probably related to that.<o:p></o:p></p>
</blockquote>
<div>
<p class="MsoNormal">Thanks!<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Hmm, the clangd tests are supposed to be disabled on PS4 for exactly these sorts of reasons. It looks like that's only working for shell tests, not gtests though.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Lit config is a tangled mess... is there an #ifdef we can use to disable just that test on PS4 until I get this sorted out?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
Thanks<br>
Russ<br>
<br>
<br>
Repository:<br>
rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D78454/new/" target="_blank">https://reviews.llvm.org/D78454/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D78454" target="_blank">https://reviews.llvm.org/D78454</a><br>
<br>
<br>
<o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
<style type="text/css">.style1 {font-family: "Times New Roman";}</style><mc type="body"><br>
<br>
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"><br>
********************************************************************** <br>
This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify
</span><a href="mailto:siee.postmaster@sony.com" target="_blank"><span style="font-size:10.0pt;font-family:">siee.postmaster@sony.com</span></a><span style="font-size:10.0pt;font-family:"><br>
This footnote also confirms that this email message has been checked for all known viruses.<br>
Sony Interactive Entertainment Europe Limited<br>
Registered Office: 10 Great Marlborough Street, London W1F 7LP, United Kingdom<br>
Registered in England: 3277793<br>
**********************************************************************<br>
</span><span style="font-size:18.0pt;font-family:Webdings;color:green"><br>
P</span><b><i><span style="font-size:10.0pt;font-family:"> Please consider the environment before printing this e-mail</span></i></b>
</p>
</div>
</body>
</html>