<div dir="ltr">Hi Kadir,<div><br></div><div>Thank you for looking into this.</div><div>Unfortunately, I can't repro this anymore. I wonder if I had a weird stale clangd or something. Current test (now changed to armv7) does set the target properly. When I tried last time, it wasn't setting it, and was defaulting to my system's (darwin).</div><div><br></div><div>Thank you,<br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"> Filipe</div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Apr 11, 2020 at 5:20 PM Kadir Çetinkaya <<a href="mailto:kadircet@google.com">kadircet@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Filipe! Thanks for letting me know, I've sent <a href="https://reviews.llvm.org/D77944" target="_blank">https://reviews.llvm.org/D77944</a> to enable this in clangd lit config.<div><br></div><div>Regarding the failure, I can't seem to repro on machines I have access to. The premerge-tests also seems to be succeeding, please see <a href="https://results.llvm-merge-guard.org/BETA_amd64_debian_testing_clang8-626/console-log.txt" target="_blank">https://results.llvm-merge-guard.org/BETA_amd64_debian_testing_clang8-626/console-log.txt</a>.</div><div><br></div><div>Can you provide more info about how you've ran the test?</div><div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Apr 10, 2020 at 4:23 PM Filipe Cabecinhas <<a href="mailto:filcab@gmail.com" target="_blank">filcab@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Kadir,<br><br>Can you fix the target_info.test clangd test you committed in this revision, please?<br>I see you've tried fixing it later by adding `REQUIRES: x86-registered-target`, but now it's never running because that feature isn't (ever) set.<br>Here's a buildbot run showing it as unsupported (x86 target is built): <a href="http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/26746/steps/test-check-all/logs/stdio" target="_blank">http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/26746/steps/test-check-all/logs/stdio</a><div><br></div><div>I saw you tried to fix the test in r364413 ([clangd] Disable failing unittest on non-x86 platforms) because it was always failing. The problem is that, even though the feature check is needed, the test still isn't working well. I just ran it manually and didn't get the target changed from my host one.</div><div><br></div><div>Here's a diff for the feature check that you can apply to propagate the feature. But we still need to get the clangd code fixed so it picks up the target:</div><div><br></div><div>```</div><div><font face="monospace">diff --git a/clang-tools-extra/clangd/test/<a href="http://lit.cfg.py" target="_blank">lit.cfg.py</a> b/clang-tools-extra/clangd/test/<a href="http://lit.cfg.py" target="_blank">lit.cfg.py</a><br>index 5030ca356ef..54406498af0 100644<br>--- a/clang-tools-extra/clangd/test/<a href="http://lit.cfg.py" target="_blank">lit.cfg.py</a><br>+++ b/clang-tools-extra/clangd/test/<a href="http://lit.cfg.py" target="_blank">lit.cfg.py</a><br>@@ -3,6 +3,19 @@ import lit.llvm<br> lit.llvm.initialize(lit_config, config)<br> lit.llvm.llvm_config.use_clang()<br> <br>+# required for target_info.test<br>+def calculate_arch_features(arch_string):<br>+ features = []<br>+ for arch in arch_string.split():<br>+ features.append(arch.lower() + '-registered-target')<br>+ return features<br>+<br>+lit.llvm.llvm_config.feature_config(<br>+ [('--assertion-mode', {'ON': 'asserts'}),<br>+ ('--cxxflags', {r'-D_GLIBCXX_DEBUG\b': 'libstdcxx-safe-mode'}),<br>+ ('--targets-built', calculate_arch_features)<br>+ ])<br>+<br> <a href="http://config.name" target="_blank">config.name</a> = 'Clangd'<br> config.suffixes = ['.test']<br> config.excludes = ['Inputs']</font><br>```</div><div><br></div><div>Thank you,</div><div><br> Filipe<br></div></div><br clear="all"><div><div dir="ltr"> Filipe</div></div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jun 26, 2019 at 8:48 AM Kadir Cetinkaya via Phabricator via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">kadircet closed this revision.<br>
kadircet added a comment.<br>
<br>
Landed as rL364387 <<a href="https://reviews.llvm.org/rL364387" rel="noreferrer" target="_blank">https://reviews.llvm.org/rL364387</a>><br>
<br>
<br>
Repository:<br>
rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D63194/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D63194/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D63194" rel="noreferrer" target="_blank">https://reviews.llvm.org/D63194</a><br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</blockquote></div>
</blockquote></div>