<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">+ Volodymyr, Azhar<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 8, 2020, at 6:28 AM, Florian Hahn <<a href="mailto:florian_hahn@apple.com" class="">florian_hahn@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Akira,<br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Apr 7, 2020, at 21:12, Akira Hatanaka <<a href="mailto:ahatanaka@apple.com" class="">ahatanaka@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class="">Hi Adam and Florian,</div><div class=""><br class=""></div><div class="">Just to give you a heads up, I’ve made changes to the code that checks matrix size and the corresponding test case following Sam McCall’s open source patch (<a href="https://github.com/llvm/llvm-project/commit/88fbadd0f5d50ea1d310fb63da6da15b82a9be05" class="">https://github.com/llvm/llvm-project/commit/88fbadd0f5d50ea1d310fb63da6da15b82a9be05</a>). If it’s not correct or if you think there are better ways to do the check, feel free to rewrite the code I committed.</div><div class=""><br class=""></div><div class=""><span style="caret-color: rgb(0, 0, 0);" class=""><a href="https://stashweb.sd.apple.com/projects/DEVTOOLS/repos/llvm-project/pull-requests/1408/overview" class="">https://stashweb.sd.apple.com/projects/DEVTOOLS/repos/llvm-project/pull-requests/1408/overview</a></span></div></div></div></blockquote><br class=""></div><div class="">Thanks for the heads-up. I will take a look. I just noticed that internal/master started crashing for matrix code. Might be related.</div><div class=""><br class=""></div></div></div></blockquote><div><br class=""></div><div>I’m seeing aarch64-matrix-amx-versioning.cpp assert when I run the tests on my desktop machine. Is that the test you saw that was crashing? I haven’t seen this failure in any of our internal bots though, probably because the test is guarded by ‘REQUIRES: matrix-test’.</div><div><br class=""></div>Also, there was a commit by Eli Friedman which removed SequentialType from the type hierarchy. I just did the minimum to resolve the merge conflict, but it looks like there are several places that need to be fixed to handle MatrixType. Could you take a look at them too?</div><div><br class=""></div><div>Also, there are three failing opt pipeline tests:</div><div><a href="https://smooshbase.apple.com/ci/view/BuildCzar/job/apple-clang-xcode-stage1-RA/job/internal%252Fclang%252F1200/238/" class="">https://smooshbase.apple.com/ci/view/BuildCzar/job/apple-clang-xcode-stage1-RA/job/internal%252Fclang%252F1200/238/</a></div><div><br class=""></div><div>Should we cherry pick the following commit to clang 1200 or should we just fix the check strings in the tests?</div><div><br class=""></div><div><div class="" style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(0, 0, 0);"><span class="" style="font-variant-ligatures: no-common-ligatures;">Author: Florian Hahn <<a href="mailto:florian_hahn@apple.com" class="">florian_hahn@apple.com</a>></span></div><div class="" style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(0, 0, 0);"><span class="" style="font-variant-ligatures: no-common-ligatures;"> Date: Tue Apr 7 14:44:19 2020 +0100</span></div><div class="" style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(0, 0, 0); min-height: 13px;"><span class="" style="font-variant-ligatures: no-common-ligatures;"></span><br class=""></div><div class="" style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(0, 0, 0);"><span class="" style="font-variant-ligatures: no-common-ligatures;"> [Matrix] Preserve LI in TileBuilder.</span></div></div><div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class="">Cheers,</div><div class="">Florian</div><br class=""></div></div></blockquote></div><br class=""></div></body></html>