<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif">Yup 32-bit vis 64-bit does dis trip linux tests, too some time back. We ended up passing explicit target triples to avoid host architecture leaking into the test. </div><div class="gmail_default" style="font-family:verdana,sans-serif"><br></div><div class="gmail_default" style="font-family:verdana,sans-serif">On a side note, shouldn't we pass -nocudalib via /clang: ?</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 6, 2020 at 7:05 AM Hans Wennborg <<a href="mailto:hans@chromium.org">hans@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Oh no, the warning is a red herring. The problem is I'm doing a 32-bit<br>
build and the triple is nvptx-nvidia-cuda, not nvptx64-nvidia-cuda.<br>
<br>
f8e1fc20cb3 should fix.<br>
<br>
On Mon, Apr 6, 2020 at 3:54 PM Hans Wennborg <<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>> wrote:<br>
><br>
> I'm seeing this failure when trying to build the Windows package for<br>
> <a href="http://llvm.org/builds" rel="noreferrer" target="_blank">http://llvm.org/builds</a> (yes, it's been a while). Not sure why it<br>
> hasn't been on the bots (maybe the Windows bots don't build the nvptx<br>
> target). Anyway, the error comes from "nocudalib" not being a valid<br>
> clang-cl option. Is it supposed to be?<br>
><br>
> FAIL: Clang :: Driver/<a href="http://cl-options.cu" rel="noreferrer" target="_blank">cl-options.cu</a> (5411 of 17056)<br>
> ******************** TEST 'Clang :: Driver/<a href="http://cl-options.cu" rel="noreferrer" target="_blank">cl-options.cu</a>' FAILED<br>
> ********************<br>
> Script:<br>
> --<br>
> : 'RUN: at line 11';<br>
> c:\src\llvm_package_64c23127\build32_stage0\bin\clang.exe<br>
> --driver-mode=cl -### -nocudalib -nocudainc --<br>
> C:\src\llvm_package_64c23127\llvm-project\clang\test\Driver\<a href="http://cl-options.cu" rel="noreferrer" target="_blank">cl-options.cu</a><br>
> 2>&1 | c:\src\llvm_package_64c23127\build32_stage0\bin\filecheck.exe<br>
> -check-prefix=GS-default<br>
> C:\src\llvm_package_64c23127\llvm-project\clang\test\Driver\<a href="http://cl-options.cu" rel="noreferrer" target="_blank">cl-options.cu</a><br>
> : 'RUN: at line 18';<br>
> c:\src\llvm_package_64c23127\build32_stage0\bin\clang.exe<br>
> --driver-mode=cl /c /GX -### -nocudalib -nocudainc --<br>
> C:\src\llvm_package_64c23127\llvm-project\clang\test\Driver\<a href="http://cl-options.cu" rel="noreferrer" target="_blank">cl-options.cu</a><br>
> 2>&1 | c:\src\llvm_package_64c23127\build32_stage0\bin\filecheck.exe<br>
> -check-prefix=GX<br>
> C:\src\llvm_package_64c23127\llvm-project\clang\test\Driver\<a href="http://cl-options.cu" rel="noreferrer" target="_blank">cl-options.cu</a><br>
> : 'RUN: at line 26';<br>
> c:\src\llvm_package_64c23127\build32_stage0\bin\clang.exe<br>
> --driver-mode=cl /c /Gd -### -nocudalib -nocudainc --<br>
> C:\src\llvm_package_64c23127\llvm-project\clang\test\Driver\<a href="http://cl-options.cu" rel="noreferrer" target="_blank">cl-options.cu</a><br>
> 2>&1 | c:\src\llvm_package_64c23127\build32_stage0\bin\filecheck.exe<br>
> -check-prefix=Gd<br>
> C:\src\llvm_package_64c23127\llvm-project\clang\test\Driver\<a href="http://cl-options.cu" rel="noreferrer" target="_blank">cl-options.cu</a><br>
> --<br>
> Exit Code: 1<br>
><br>
> Command Output (stdout):<br>
> --<br>
> $ ":" "RUN: at line 11"<br>
> $ "c:\src\llvm_package_64c23127\build32_stage0\bin\clang.exe"<br>
> "--driver-mode=cl" "-###" "-nocudalib" "-nocudainc" "--"<br>
> "C:\src\llvm_package_64c23127\llvm-project\clang\test\Driver\<a href="http://cl-options.cu" rel="noreferrer" target="_blank">cl-options.cu</a>"<br>
> $ "c:\src\llvm_package_64c23127\build32_stage0\bin\filecheck.exe"<br>
> "-check-prefix=GS-default"<br>
> "C:\src\llvm_package_64c23127\llvm-project\clang\test\Driver\<a href="http://cl-options.cu" rel="noreferrer" target="_blank">cl-options.cu</a>"<br>
> # command stderr:<br>
> C:\src\llvm_package_64c23127\llvm-project\clang\test\Driver\cl-options.cu:12:16:<br>
> error: GS-default: expected string not found in input<br>
> // GS-default: "-cc1" "-triple" "nvptx64-nvidia-cuda"<br>
>                ^<br>
> <stdin>:1:1: note: scanning from here<br>
> clang: warning: unknown argument ignored in clang-cl: '-nocudalib'<br>
> [-Wunknown-argument]<br>
> ^<br>
><br>
> On Thu, Mar 12, 2020 at 12:07 AM Artem Belevich via cfe-commits<br>
> <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
> ><br>
> ><br>
> > Author: Artem Belevich<br>
> > Date: 2020-03-11T16:06:09-07:00<br>
> > New Revision: 8527c1ed66c63db0590cd69320ba0bf8fad59b87<br>
> ><br>
> > URL: <a href="https://github.com/llvm/llvm-project/commit/8527c1ed66c63db0590cd69320ba0bf8fad59b87" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/8527c1ed66c63db0590cd69320ba0bf8fad59b87</a><br>
> > DIFF: <a href="https://github.com/llvm/llvm-project/commit/8527c1ed66c63db0590cd69320ba0bf8fad59b87.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/8527c1ed66c63db0590cd69320ba0bf8fad59b87.diff</a><br>
> ><br>
> > LOG: Added constraints on <a href="http://cl-options.cu" rel="noreferrer" target="_blank">cl-options.cu</a> test<br>
> ><br>
> > Added:<br>
> ><br>
> ><br>
> > Modified:<br>
> >     clang/test/Driver/<a href="http://cl-options.cu" rel="noreferrer" target="_blank">cl-options.cu</a><br>
> ><br>
> > Removed:<br>
> ><br>
> ><br>
> ><br>
> > ################################################################################<br>
> > diff  --git a/clang/test/Driver/<a href="http://cl-options.cu" rel="noreferrer" target="_blank">cl-options.cu</a> b/clang/test/Driver/<a href="http://cl-options.cu" rel="noreferrer" target="_blank">cl-options.cu</a><br>
> > index 7597970af160..2fd393e06d2d 100644<br>
> > --- a/clang/test/Driver/<a href="http://cl-options.cu" rel="noreferrer" target="_blank">cl-options.cu</a><br>
> > +++ b/clang/test/Driver/<a href="http://cl-options.cu" rel="noreferrer" target="_blank">cl-options.cu</a><br>
> > @@ -3,6 +3,10 @@<br>
> >  // Note: %s must be preceded by --, otherwise it may be interpreted as a<br>
> >  // command-line option, e.g. on Mac where %s is commonly under /Users.<br>
> ><br>
> > +// REQUIRES: clang-driver<br>
> > +// REQUIRES: x86-registered-target<br>
> > +// REQUIRES: nvptx-registered-target<br>
> > +<br>
> >  // -stack-protector should not be passed to device-side CUDA compilation<br>
> >  // RUN: %clang_cl -### -nocudalib -nocudainc -- %s 2>&1 | FileCheck -check-prefix=GS-default %s<br>
> >  // GS-default: "-cc1" "-triple" "nvptx64-nvidia-cuda"<br>
> ><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > cfe-commits mailing list<br>
> > <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> > <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr">--Artem Belevich</div></div>