<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
On 4/6/20 9:06 AM, Roman Lebedev wrote:<br>
<blockquote type="cite"
cite="mid:CADoyv_5npyJwGBYU-k8aCQ3OkNaAiz1VwDEqGwRZ3HzMC6_Hvg@mail.gmail.com">
<pre class="moz-quote-pre" wrap="">This seems suspicious.</pre>
</blockquote>
<br>
<p><font face="Hack Nerd Font Mono">Agreed, especially since this is
also not the only place.</font></p>
<p><font face="Hack Nerd Font Mono">I was hoping to unblock the
builders with this.<br>
</font></p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:CADoyv_5npyJwGBYU-k8aCQ3OkNaAiz1VwDEqGwRZ3HzMC6_Hvg@mail.gmail.com">
<pre class="moz-quote-pre" wrap="">
Does clang-reorder-fields actually explicitly needs something from
FrontendOpenMP?
If not, it looks like there dependency is missing elsewhere, or
there's wrong layering.
</pre>
</blockquote>
<p>The root cause is the use of `isAllowedClauseForDirective` in
ASTMatchers.h.<br>
</p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:CADoyv_5npyJwGBYU-k8aCQ3OkNaAiz1VwDEqGwRZ3HzMC6_Hvg@mail.gmail.com">
<pre class="moz-quote-pre" wrap="">
On Mon, Apr 6, 2020 at 5:03 PM Johannes Doerfert via cfe-commits
<a class="moz-txt-link-rfc2396E" href="mailto:cfe-commits@lists.llvm.org"><cfe-commits@lists.llvm.org></a> wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
Author: Johannes Doerfert
Date: 2020-04-06T09:01:43-05:00
New Revision: 9e1af172eec9a06bffac337057a2452b88466288
URL: <a class="moz-txt-link-freetext" href="https://github.com/llvm/llvm-project/commit/9e1af172eec9a06bffac337057a2452b88466288">https://github.com/llvm/llvm-project/commit/9e1af172eec9a06bffac337057a2452b88466288</a>
DIFF: <a class="moz-txt-link-freetext" href="https://github.com/llvm/llvm-project/commit/9e1af172eec9a06bffac337057a2452b88466288.diff">https://github.com/llvm/llvm-project/commit/9e1af172eec9a06bffac337057a2452b88466288.diff</a>
LOG: [OpenMP][FIX] Add missing cmake dependence needed after 931c0cd713ee
Added:
Modified:
clang-tools-extra/clang-reorder-fields/CMakeLists.txt
Removed:
################################################################################
diff --git a/clang-tools-extra/clang-reorder-fields/CMakeLists.txt b/clang-tools-extra/clang-reorder-fields/CMakeLists.txt
index 9c75d785cc9a..c357d0a3cfbf 100644
--- a/clang-tools-extra/clang-reorder-fields/CMakeLists.txt
+++ b/clang-tools-extra/clang-reorder-fields/CMakeLists.txt
@@ -1,4 +1,7 @@
-set(LLVM_LINK_COMPONENTS support)
+set(LLVM_LINK_COMPONENTS
+ FrontendOpenMP
+ support
+)
add_clang_library(clangReorderFields
ReorderFieldsAction.cpp
_______________________________________________
cfe-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a>
</pre>
</blockquote>
</blockquote>
</body>
</html>