<div dir="ltr">Usually this sort of thing is addressed with llvm_unreachable, rather than a return statement that's not expected to be reached by any valid execution of LLVM (it'd require a carefully hand-crafted CPU kind to reach that return (since all the actual enumerators result in returns earlier, in the switch statement above), which probably isn't an intended code path?)<br><br>I've made that change in 819e540208d5d62e7841d0dbdef3580eecc2c2b6</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 25, 2020 at 9:59 PM Michael Liao via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Michael Liao<br>
Date: 2020-03-26T00:53:24-04:00<br>
New Revision: d264f02c6f502960e2bcdd332f250efc702d09f2<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/d264f02c6f502960e2bcdd332f250efc702d09f2" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/d264f02c6f502960e2bcdd332f250efc702d09f2</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/d264f02c6f502960e2bcdd332f250efc702d09f2.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/d264f02c6f502960e2bcdd332f250efc702d09f2.diff</a><br>
<br>
LOG: Fix `-Wreturn-type` warning. NFC.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    clang/lib/Basic/Targets/X86.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/clang/lib/Basic/Targets/X86.cpp b/clang/lib/Basic/Targets/X86.cpp<br>
index f35b520de657..8a7d0f17760e 100644<br>
--- a/clang/lib/Basic/Targets/X86.cpp<br>
+++ b/clang/lib/Basic/Targets/X86.cpp<br>
@@ -1842,6 +1842,7 @@ Optional<unsigned> X86TargetInfo::getCPUCacheLineSize() const {<br>
     case CK_Generic:<br>
       return None;<br>
   }<br>
+  return None;<br>
 }<br>
<br>
 bool X86TargetInfo::validateOutputSize(const llvm::StringMap<bool> &FeatureMap,<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>