<div dir="ltr">Why the change? this seems counter to LLVM's style which pretty consistently uses unreachable rather than assert(false), so far as I know?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Mar 10, 2020 at 11:22 AM Aaron Ballman via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Aaron Ballman<br>
Date: 2020-03-10T14:22:21-04:00<br>
New Revision: 4a0267e3ad8c4d47f267d7d960f127e099fb4818<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/4a0267e3ad8c4d47f267d7d960f127e099fb4818" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/4a0267e3ad8c4d47f267d7d960f127e099fb4818</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/4a0267e3ad8c4d47f267d7d960f127e099fb4818.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/4a0267e3ad8c4d47f267d7d960f127e099fb4818.diff</a><br>
<br>
LOG: Convert a reachable llvm_unreachable into an assert.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    clang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/clang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp b/clang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp<br>
index 01ac2bc83bb6..99e16752b51a 100644<br>
--- a/clang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp<br>
+++ b/clang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp<br>
@@ -134,9 +134,9 @@ StringRef AnalyzerOptions::getCheckerStringOption(StringRef CheckerName,<br>
     CheckerName = CheckerName.substr(0, Pos);<br>
   } while (!CheckerName.empty() && SearchInParents);<br>
<br>
-  llvm_unreachable("Unknown checker option! Did you call getChecker*Option "<br>
-                   "with incorrect parameters? User input must've been "<br>
-                   "verified by CheckerRegistry.");<br>
+  assert(false && "Unknown checker option! Did you call getChecker*Option "<br>
+                  "with incorrect parameters? User input must've been "<br>
+                  "verified by CheckerRegistry.");<br>
<br>
   return "";<br>
 }<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>