<div dir="ltr">Does "isIntegerConstantExpr" have side effects that are desired/necessary? Otherwise please change this to roll the isIntegerConstantExpr into the assert (so that it is only executed when asserts are enabled)</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Mar 10, 2020 at 10:11 AM Mikhail Maltsev via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Mikhail Maltsev<br>
Date: 2020-03-10T17:10:52Z<br>
New Revision: 43606efb6847fc9c79e7d93760a2a6191e8a8539<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/43606efb6847fc9c79e7d93760a2a6191e8a8539" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/43606efb6847fc9c79e7d93760a2a6191e8a8539</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/43606efb6847fc9c79e7d93760a2a6191e8a8539.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/43606efb6847fc9c79e7d93760a2a6191e8a8539.diff</a><br>
<br>
LOG: Suppress an "unused variable" warning in release build<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    clang/lib/Sema/SemaChecking.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp<br>
index 24d0d9209a1d..8a2b4b019663 100644<br>
--- a/clang/lib/Sema/SemaChecking.cpp<br>
+++ b/clang/lib/Sema/SemaChecking.cpp<br>
@@ -2094,6 +2094,7 @@ bool Sema::CheckARMCoprocessorImmediate(const Expr *CoprocArg, bool WantCDE) {<br>
<br>
   llvm::APSInt CoprocNoAP;<br>
   bool IsICE = CoprocArg->isIntegerConstantExpr(CoprocNoAP, Context);<br>
+  (void)IsICE;<br>
   assert(IsICE && "Coprocossor immediate is not a constant expression");<br>
   int64_t CoprocNo = CoprocNoAP.getExtValue();<br>
   assert(CoprocNo >= 0 && "Coprocessor immediate must be non-negative");<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>