<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<p>Sorry, will do. This was something I had intended to do in the
original commit.</p>
<p>Thanks,</p>
<p>Stephen.<br>
</p>
<div class="moz-cite-prefix">On 05/01/2020 22:00, Aaron Ballman
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAAt6xTvMknx0CfAmJLmyaub9rU4Grf_t5N72vdVxV7cga1uFUA@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="auto">Can you also include more detail in commit logs
than this? It doesn't explain why this is an oversight, which
makes code archaeology harder later.</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sun, Jan 5, 2020, 3:32 PM
Stephen Kelly via cfe-commits <<a
href="mailto:cfe-commits@lists.llvm.org"
moz-do-not-send="true">cfe-commits@lists.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Author: Stephen Kelly<br>
Date: 2020-01-05T20:27:37Z<br>
New Revision: 471151238438201f3fe365a7784f1a091328e46c<br>
<br>
URL: <a
href="https://github.com/llvm/llvm-project/commit/471151238438201f3fe365a7784f1a091328e46c"
rel="noreferrer noreferrer" target="_blank"
moz-do-not-send="true">https://github.com/llvm/llvm-project/commit/471151238438201f3fe365a7784f1a091328e46c</a><br>
DIFF: <a
href="https://github.com/llvm/llvm-project/commit/471151238438201f3fe365a7784f1a091328e46c.diff"
rel="noreferrer noreferrer" target="_blank"
moz-do-not-send="true">https://github.com/llvm/llvm-project/commit/471151238438201f3fe365a7784f1a091328e46c.diff</a><br>
<br>
LOG: Fix oversight in AST traversal helper<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
clang/lib/AST/Expr.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/clang/lib/AST/Expr.cpp b/clang/lib/AST/Expr.cpp<br>
index 5c9ceac854cf..73ddbc62482d 100644<br>
--- a/clang/lib/AST/Expr.cpp<br>
+++ b/clang/lib/AST/Expr.cpp<br>
@@ -3026,7 +3026,7 @@ Expr
*Expr::IgnoreUnlessSpelledInSource() {<br>
Expr *LastE = nullptr;<br>
while (E != LastE) {<br>
LastE = E;<br>
- E = E->IgnoreImplicit();<br>
+ E = E->IgnoreParenImpCasts();<br>
<br>
auto SR = E->getSourceRange();<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank"
rel="noreferrer" moz-do-not-send="true">cfe-commits@lists.llvm.org</a><br>
<a
href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits"
rel="noreferrer noreferrer" target="_blank"
moz-do-not-send="true">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote>
</div>
</blockquote>
</body>
</html>