<html><body><p><font size="2">Sam McCall wrote:</font><br><br><tt>>LOG: [clangd] Reapply b60896fad926 Fall back to selecting token-before-cursor if token-after-cursor fails.<br>><br>>This reverts commit 8f876d5105507f874c0fb86bc779c9853eab3fe2.<br></tt><br><tt>I believe this has caused a significant number of build bot failures,</tt><br><tt>with error messages along these lines:</tt><br><tt>(see </tt><a href="http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/28908/steps/build%20stage%201/logs/stdio"><tt>http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/28908/steps/build%20stage%201/logs/stdio</tt></a><tt>)</tt><br><br><br><tt>In file included from /usr/include/c++/7/memory:64:0,<br> from /home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/llvm/include/llvm/ADT/Optional.h:22,<br> from /home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/clang-tools-extra/clangd/../clang-tidy/ClangTidyOptions.h:13,<br> from /home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/clang-tools-extra/clangd/ClangdServer.h:12,<br> from /home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/clang-tools-extra/clangd/ClangdServer.cpp:9:<br>/usr/include/c++/7/bits/stl_construct.h: In instantiation of 'void std::_Construct(_T1*, _Args&& ...) [with _T1 = clang::clangd::Tweak::Selection; _Args = {const clang::clangd::Tweak::Selection&}]':<br>/usr/include/c++/7/bits/stl_uninitialized.h:83:18: required from 'static _ForwardIterator std::__uninitialized_copy<_TrivialValueTypes>::__uninit_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = __gnu_cxx::__normal_iterator<const clang::clangd::Tweak::Selection*, std::vector<clang::clangd::Tweak::Selection> >; _ForwardIterator = clang::clangd::Tweak::Selection*; bool _TrivialValueTypes = false]'<br>/usr/include/c++/7/bits/stl_uninitialized.h:134:15: required from '_ForwardIterator std::uninitialized_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = __gnu_cxx::__normal_iterator<const clang::clangd::Tweak::Selection*, std::vector<clang::clangd::Tweak::Selection> >; _ForwardIterator = clang::clangd::Tweak::Selection*]'<br>/usr/include/c++/7/bits/stl_uninitialized.h:289:37: required from '_ForwardIterator std::__uninitialized_copy_a(_InputIterator, _InputIterator, _ForwardIterator, std::allocator<_Tp>&) [with _InputIterator = __gnu_cxx::__normal_iterator<const clang::clangd::Tweak::Selection*, std::vector<clang::clangd::Tweak::Selection> >; _ForwardIterator = clang::clangd::Tweak::Selection*; _Tp = clang::clangd::Tweak::Selection]'<br>/usr/include/c++/7/bits/stl_vector.h:331:31: required from 'std::vector<_Tp, _Alloc>::vector(const std::vector<_Tp, _Alloc>&) [with _Tp = clang::clangd::Tweak::Selection; _Alloc = std::allocator<clang::clangd::Tweak::Selection>]'<br>/home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/llvm/include/llvm/Support/Error.h:483:5: required from 'llvm::Expected<T>::Expected(OtherT&&, typename std::enable_if<std::is_convertible<OtherT, T>::value>::type*) [with OtherT = std::vector<clang::clangd::Tweak::Selection>&; T = std::vector<clang::clangd::Tweak::Selection>; typename std::enable_if<std::is_convertible<OtherT, T>::value>::type = void]'<br>/home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/clang-tools-extra/clangd/ClangdServer.cpp:394:10: required from here<br>/usr/include/c++/7/bits/stl_construct.h:75:7: error: use of deleted function 'clang::clangd::Tweak::Selection::Selection(const clang::clangd::Tweak::Selection&)'<br> { ::new(static_cast<void*>(__p)) _T1(std::forward<_Args>(__args)...); }<br> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>In file included from /home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/clang-tools-extra/clangd/ClangdServer.h:28:0,<br> from /home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/clang-tools-extra/clangd/ClangdServer.cpp:9:<br>/home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/clang-tools-extra/clangd/refactor/Tweak.h:49:10: note: 'clang::clangd::Tweak::Selection::Selection(const clang::clangd::Tweak::Selection&)' is implicitly deleted because the default definition would be ill-formed:<br> struct Selection {<br> ^~~~~~~~~<br>/home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/clang-tools-extra/clangd/refactor/Tweak.h:49:10: error: use of deleted function 'clang::clangd::SelectionTree::SelectionTree(const clang::clangd::SelectionTree&)'<br>In file included from /home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/clang-tools-extra/clangd/refactor/Tweak.h:25:0,<br> from /home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/clang-tools-extra/clangd/ClangdServer.h:28,<br> from /home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/clang-tools-extra/clangd/ClangdServer.cpp:9:<br>/home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/clang-tools-extra/clangd/Selection.h:96:3: note: declared here<br> SelectionTree(const SelectionTree &) = delete;<br> ^~~~~~~~~~~~~<br></tt><br><br><font size="2">Bye,</font><br><font size="2">Ulrich</font><br><BR>
</body></html>