<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
p.msipheader4d0fcdd7, li.msipheader4d0fcdd7, div.msipheader4d0fcdd7
{mso-style-name:msipheader4d0fcdd7;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="msipheader4d0fcdd7" style="margin:0in;margin-bottom:.0001pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#0078D7">[AMD Official Use Only - Internal Distribution Only]</span><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thank You! Eric for clarifying this. I wasn’t sure about this.
<o:p></o:p></p>
<p class="MsoNormal">I don’t know why my git script missed that string in commit message, and allowed me to commit it.
<o:p></o:p></p>
<p class="MsoNormal">Any way thanks again.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Eric Christopher <echristo@gmail.com> <br>
<b>Sent:</b> Wednesday, December 11, 2019 1:24 AM<br>
<b>To:</b> Tomar, Sourabh Singh <SourabhSingh.Tomar@amd.com>; Sourabh Singh Tomar <llvmlistbot@llvm.org><br>
<b>Cc:</b> Clang Commits <cfe-commits@lists.llvm.org><br>
<b>Subject:</b> Re: [clang] d82b6ba - Revert "[DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified."<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">[CAUTION: External Email] <o:p></o:p></p>
<div>
<div>
<p class="MsoNormal">You don't need to revert for a missing differential revision, just close the revision yourself :)
<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">-eric<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Tue, Dec 10, 2019 at 11:51 AM Sourabh Singh Tomar via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<p class="MsoNormal"><br>
Author: Sourabh Singh Tomar<br>
Date: 2019-12-11T01:20:40+05:30<br>
New Revision: d82b6ba21b32ddf00af886b9160feef88211773e<br>
<br>
URL: <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project%2Fcommit%2Fd82b6ba21b32ddf00af886b9160feef88211773e&data=02%7C01%7CSourabhSingh.Tomar%40amd.com%7Cfbedcd2f28364ee2b93308d77daab84c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637116044519270228&sdata=PiOGox%2Bou%2Fh86nY9xlMDibkao2WWE6SsKdVHYgz6tWk%3D&reserved=0" target="_blank">
https://github.com/llvm/llvm-project/commit/d82b6ba21b32ddf00af886b9160feef88211773e</a><br>
DIFF: <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project%2Fcommit%2Fd82b6ba21b32ddf00af886b9160feef88211773e.diff&data=02%7C01%7CSourabhSingh.Tomar%40amd.com%7Cfbedcd2f28364ee2b93308d77daab84c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637116044519270228&sdata=ry1QJ43mKjnflU1Dm9p2z04L76ACjYSwDElCaLG9WFM%3D&reserved=0" target="_blank">
https://github.com/llvm/llvm-project/commit/d82b6ba21b32ddf00af886b9160feef88211773e.diff</a><br>
<br>
LOG: Revert "[DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified."<br>
<br>
This reverts commit 6ef01588f4d75ef43da4ed2a37ba7a8b8daab259.<br>
Missing Differetial revision.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
clang/test/CodeGen/split-debug-output.c<br>
clang/test/CodeGen/thinlto-split-dwarf.c<br>
llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp<br>
llvm/test/DebugInfo/X86/debug_addr.ll<br>
llvm/test/DebugInfo/X86/string-offsets-table.ll<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/clang/test/CodeGen/split-debug-output.c b/clang/test/CodeGen/split-debug-output.c<br>
index 19569f8d574b..1507edd24849 100644<br>
--- a/clang/test/CodeGen/split-debug-output.c<br>
+++ b/clang/test/CodeGen/split-debug-output.c<br>
@@ -1,11 +1,7 @@<br>
// REQUIRES: x86-registered-target<br>
-// RUN: %clang_cc1 -triple x86_64-unknown-linux -debug-info-kind=limited -dwarf-version=4 -split-dwarf-file foo.dwo -split-dwarf-output %t -emit-obj -o - %s | llvm-dwarfdump -debug-info - | FileCheck --check-prefix=DWARFv4 %s<br>
-// RUN: llvm-dwarfdump -debug-info %t | FileCheck --check-prefix=DWARFv4 %s<br>
-<br>
-// RUN: %clang_cc1 -triple x86_64-unknown-linux -debug-info-kind=limited -dwarf-version=5 -split-dwarf-file foo.dwo -split-dwarf-output %t -emit-obj -o - %s | llvm-dwarfdump -debug-info - | FileCheck --check-prefix=DWARFv5 %s<br>
-// RUN: llvm-dwarfdump -debug-info %t | FileCheck --check-prefix=DWARFv5 %s<br>
+// RUN: %clang_cc1 -triple x86_64-unknown-linux -debug-info-kind=limited -split-dwarf-file foo.dwo -split-dwarf-output %t -emit-obj -o - %s | llvm-dwarfdump -debug-info - | FileCheck %s<br>
+// RUN: llvm-dwarfdump -debug-info %t | FileCheck %s<br>
<br>
int f() { return 0; }<br>
<br>
-// DWARFv4: DW_AT_GNU_dwo_name ("foo.dwo")<br>
-// DWARFv5: DW_AT_dwo_name ("foo.dwo")<br>
+// CHECK: DW_AT_GNU_dwo_name ("foo.dwo")<br>
<br>
diff --git a/clang/test/CodeGen/thinlto-split-dwarf.c b/clang/test/CodeGen/thinlto-split-dwarf.c<br>
index 419bd1320bb2..60649b0881bb 100644<br>
--- a/clang/test/CodeGen/thinlto-split-dwarf.c<br>
+++ b/clang/test/CodeGen/thinlto-split-dwarf.c<br>
@@ -13,31 +13,11 @@<br>
// RUN: -o %t.native.o -split-dwarf-file %t.file.dwo \<br>
// RUN: -split-dwarf-output %t.output.dwo -x ir %t.o<br>
<br>
-// RUN: llvm-dwarfdump %t.native.o | FileCheck --check-prefix=DWARFv4-O %s<br>
-// RUN: llvm-dwarfdump %t.output.dwo | FileCheck --check-prefix=DWARFv4-DWO %s<br>
+// RUN: llvm-dwarfdump %t.native.o | FileCheck --check-prefix=O %s<br>
+// RUN: llvm-dwarfdump %t.output.dwo | FileCheck --check-prefix=DWO %s<br>
<br>
-// DWARFv4-O: DW_AT_GNU_dwo_name ("{{.*}}.file.dwo")<br>
-// DWARFv4-O-NOT: DW_TAG_subprogram<br>
-// DWARFv4-DWO: DW_TAG_subprogram<br>
-<br>
-// RUN: %clang_cc1 -debug-info-kind=limited -dwarf-version=5 -triple x86_64-unknown-linux-gnu \<br>
-// RUN: -flto=thin -emit-llvm-bc \<br>
-// RUN: -o %t.o %s<br>
-<br>
-// RUN: llvm-lto2 run -thinlto-distributed-indexes %t.o \<br>
-// RUN: -o %t2.index \<br>
-// RUN: -r=%t.o,main,px<br>
-<br>
-// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu \<br>
-// RUN: -emit-obj -fthinlto-index=%t.o.thinlto.bc \<br>
-// RUN: -o %t.native.o -dwarf-version=5 -split-dwarf-file %t.file.dwo \<br>
-// RUN: -split-dwarf-output %t.output.dwo -x ir %t.o<br>
-<br>
-// RUN: llvm-dwarfdump %t.native.o | FileCheck --check-prefix=DWARFv5-O %s<br>
-// RUN: llvm-dwarfdump %t.output.dwo | FileCheck --check-prefix=DWARFv5-DWO %s<br>
-<br>
-// DWARFv5-O: DW_AT_dwo_name ("{{.*}}.file.dwo")<br>
-// DWARFv5-O-NOT: DW_TAG_subprogram<br>
-// DWARFv5-DWO: DW_TAG_subprogram<br>
+// O: DW_AT_GNU_dwo_name ("{{.*}}.file.dwo")<br>
+// O-NOT: DW_TAG_subprogram<br>
+// DWO: DW_TAG_subprogram<br>
<br>
int main() {}<br>
<br>
diff --git a/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp b/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
index f6039cc5bc00..89a0e350f8fe 100644<br>
--- a/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
+++ b/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
@@ -856,13 +856,10 @@ void DwarfDebug::finishUnitAttributes(const DICompileUnit *DIUnit,<br>
// This CU is either a clang module DWO or a skeleton CU.<br>
NewCU.addUInt(Die, dwarf::DW_AT_GNU_dwo_id, dwarf::DW_FORM_data8,<br>
DIUnit->getDWOId());<br>
- if (!DIUnit->getSplitDebugFilename().empty()) {<br>
+ if (!DIUnit->getSplitDebugFilename().empty())<br>
// This is a prefabricated skeleton CU.<br>
- dwarf::Attribute attrDWOName = getDwarfVersion() >= 5<br>
- ? dwarf::DW_AT_dwo_name<br>
- : dwarf::DW_AT_GNU_dwo_name;<br>
- NewCU.addString(Die, attrDWOName, DIUnit->getSplitDebugFilename());<br>
- }<br>
+ NewCU.addString(Die, dwarf::DW_AT_GNU_dwo_name,<br>
+ DIUnit->getSplitDebugFilename());<br>
}<br>
}<br>
// Create new DwarfCompileUnit for the given metadata node with tag<br>
@@ -1104,13 +1101,10 @@ void DwarfDebug::finalizeModuleInfo() {<br>
bool HasSplitUnit = SkCU && !TheCU.getUnitDie().children().empty();<br>
<br>
if (HasSplitUnit) {<br>
- dwarf::Attribute attrDWOName = getDwarfVersion() >= 5<br>
- ? dwarf::DW_AT_dwo_name<br>
- : dwarf::DW_AT_GNU_dwo_name;<br>
finishUnitAttributes(TheCU.getCUNode(), TheCU);<br>
- TheCU.addString(TheCU.getUnitDie(), attrDWOName,<br>
+ TheCU.addString(TheCU.getUnitDie(), dwarf::DW_AT_GNU_dwo_name,<br>
Asm->TM.Options.MCOptions.SplitDwarfFile);<br>
- SkCU->addString(SkCU->getUnitDie(), attrDWOName,<br>
+ SkCU->addString(SkCU->getUnitDie(), dwarf::DW_AT_GNU_dwo_name,<br>
Asm->TM.Options.MCOptions.SplitDwarfFile);<br>
// Emit a unique identifier for this CU.<br>
uint64_t ID =<br>
<br>
diff --git a/llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp b/llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp<br>
index 02f915bc6f7b..4ccda628093c 100644<br>
--- a/llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp<br>
+++ b/llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp<br>
@@ -554,9 +554,7 @@ bool DWARFUnit::parseDWO() {<br>
DWARFDie UnitDie = getUnitDIE();<br>
if (!UnitDie)<br>
return false;<br>
- auto DWOFileName = getVersion() >= 5<br>
- ? dwarf::toString(UnitDie.find(DW_AT_dwo_name))<br>
- : dwarf::toString(UnitDie.find(DW_AT_GNU_dwo_name));<br>
+ auto DWOFileName = dwarf::toString(UnitDie.find(DW_AT_GNU_dwo_name));<br>
if (!DWOFileName)<br>
return false;<br>
auto CompilationDir = dwarf::toString(UnitDie.find(DW_AT_comp_dir));<br>
<br>
diff --git a/llvm/test/DebugInfo/X86/debug_addr.ll b/llvm/test/DebugInfo/X86/debug_addr.ll<br>
index 424313ac2e64..55e24b2764c1 100644<br>
--- a/llvm/test/DebugInfo/X86/debug_addr.ll<br>
+++ b/llvm/test/DebugInfo/X86/debug_addr.ll<br>
@@ -30,7 +30,7 @@<br>
; DWARF5-NOT: Compile Unit<br>
; DWARF5: DW_TAG_skeleton_unit<br>
; DWARF5-NOT: DW_TAG_{{.*}}<br>
-; DWARF5: DW_AT_dwo_name{{.*}}test.dwo<br>
+; DWARF5: DW_AT_GNU_dwo_name{{.*}}test.dwo<br>
; DWARF5: DW_AT_addr_base{{.*}}0x00000008<br>
; DWARF5: DW_AT_low_pc [DW_FORM_addrx] (indexed (00000000) address = 0x0000000000000000 ".text")<br>
; DWARF5: .debug_addr contents:<br>
<br>
diff --git a/llvm/test/DebugInfo/X86/string-offsets-table.ll b/llvm/test/DebugInfo/X86/string-offsets-table.ll<br>
index cff779445ed2..be960d1e017c 100644<br>
--- a/llvm/test/DebugInfo/X86/string-offsets-table.ll<br>
+++ b/llvm/test/DebugInfo/X86/string-offsets-table.ll<br>
@@ -60,7 +60,7 @@<br>
; SPLIT-NOT: {{DW_TAG|contents:}}<br>
; SPLIT: DW_AT_str_offsets_base [DW_FORM_sec_offset] (0x00000008)<br>
; SPLIT: DW_AT_comp_dir [DW_FORM_strx1] (indexed (00000000) string = "/home/test")<br>
-; SPLIT: DW_AT_dwo_name [DW_FORM_strx1] (indexed (00000001) string = "foo.dwo")<br>
+; SPLIT: DW_AT_GNU_dwo_name [DW_FORM_strx1] (indexed (00000001) string = "foo.dwo")<br>
<br>
; Check for the split CU in .debug_info.dwo.<br>
; SPLIT: .debug_info.dwo contents:<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.llvm.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fcfe-commits&data=02%7C01%7CSourabhSingh.Tomar%40amd.com%7Cfbedcd2f28364ee2b93308d77daab84c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637116044519280221&sdata=RearHhzs4zcQOMRezolgH8YMXmMpiVKuF7ixQUYYdAI%3D&reserved=0" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</body>
</html>