<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi All,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Apologies for the delay in responding, I was away from keyboard (llvm dev conf).</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
This is a real funny patch! It is a (simple) fix that uncovers quite a few things. Anyway, t<span style="color: rgb(0, 0, 0); font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;">hanks Michael for your analysis! As I will need to make some
changes this time (this wasn't the case last time), I definitely definitely open a new review soon.</span></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Cheers,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Sjoerd.</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Michael Kruse <llvm-commits@meinersbur.de><br>
<b>Sent:</b> 25 October 2019 23:18<br>
<b>To:</b> Jordan Rupprecht <rupprecht@google.com><br>
<b>Cc:</b> Michael Kruse <llvm-commits@meinersbur.de>; Hans Wennborg <hans@chromium.org>; cfe-commits <cfe-commits@lists.llvm.org>; Hal Finkel <hfinkel@anl.gov>; Sjoerd Meijer <Sjoerd.Meijer@arm.com><br>
<b>Subject:</b> Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">@sjoerdmeijer<br>
<br>
Before recommitting, please re-open the patch review.<br>
<br>
Michael<br>
<br>
Am Do., 24. Okt. 2019 um 18:45 Uhr schrieb Jordan Rupprecht<br>
<rupprecht@google.com>:<br>
><br>
> Reverted in 6d424a161bf3e52730371da0b9439ed93a8ce406 due to the issue described here. Should hopefully be a trivial fix forward.<br>
><br>
> On Tue, Oct 22, 2019 at 2:46 PM Michael Kruse <llvm-commits@meinersbur.de> wrote:<br>
>><br>
>> Am Mo., 21. Okt. 2019 um 23:44 Uhr schrieb Jordan Rupprecht<br>
>> <rupprecht@google.com>:<br>
>> > At any rate, it sounds like this is not a codegen bug at all, but just an over-eager warning?<br>
>><br>
>> That interpretation is different from mine. Codgen emits the following<br>
>> from vectorize(disable)<br>
>><br>
>> !4 = !{!"llvm.loop.vectorize.enable", i1 true}<br>
>><br>
>> which is is not what I'd expect.<br>
>><br>
>> Michael<br>
</div>
</span></font></div>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose,
or store or copy the information in any medium. Thank you.
</body>
</html>