<div dir="ltr">Sounds good! Will start doing it.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 28, 2019 at 4:29 PM David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Thanks for the details! Generally it's fine to have these discussions on-list, or at least to include a summary reply so it's clear loose ends were tied up.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 28, 2019 at 4:26 PM Jian Cai <<a href="mailto:caij2003@gmail.com" target="_blank">caij2003@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi David,<div><br></div><div>Thanks for the follow up. I already discussed it with Nico over email and addressed his concerns on llvm-svn: 374932. I did not want to spam everyone with all our email exchanges so I did not include the list :). </div><div><br></div><div>Thanks,</div><div>Jian</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 28, 2019 at 3:37 PM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">+1 to what Nico said/ping on this.<br><br>Jian - could you see if these tests could be made portable as Nico's suggested?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 14, 2019 at 3:54 PM Nico Weber via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hm, this means the test can't run on non-linux, so if someone breaks it on e.g. win they won't see the failure. Maybe add a --target=i386-unknown-linux instead? Then it might pass on all platforms.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 14, 2019 at 6:48 PM Jian Cai via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: jcai19<br>
Date: Mon Oct 14 15:51:12 2019<br>
New Revision: 374837<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=374837&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=374837&view=rev</a><br>
Log:<br>
[clang] add requirements to -Wa,-W test cases.<br>
<br>
Include linux as a test requirement.<br>
<br>
Modified:<br>
    cfe/trunk/test/Driver/as-w-option.c<br>
<br>
Modified: cfe/trunk/test/Driver/as-w-option.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/as-w-option.c?rev=374837&r1=374836&r2=374837&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/as-w-option.c?rev=374837&r1=374836&r2=374837&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Driver/as-w-option.c (original)<br>
+++ cfe/trunk/test/Driver/as-w-option.c Mon Oct 14 15:51:12 2019<br>
@@ -5,6 +5,9 @@<br>
 // RUN: not %clang %s -c -o %t.o -integrated-as -Wa,--fatal-warnings 2>&1 | FileCheck --check-prefix=CHECK-AS-FATAL %s<br>
 // RUN: not %clang %s -c -o %t.o -fno-integrated-as -Wa,--fatal-warnings 2>&1 | FileCheck --check-prefix=CHECK-AS-FATAL %s<br>
<br>
+// REQUIRES: clang-driver<br>
+// REQUIRES: linux<br>
+<br>
 // CHECK-IAS: "-cc1" {{.*}} "-massembler-no-warn"<br>
 // CHECK-NOIAS: "-W"<br>
 // CHECK-AS-NOWARN-NOT: warning:<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</blockquote></div>
</blockquote></div>
</blockquote></div>