<div dir="ltr">This fails on both win and mac:<div><br></div><div><a href="http://45.33.8.238/mac/1678/step_6.txt">http://45.33.8.238/mac/1678/step_6.txt</a><br></div><div><a href="http://45.33.8.238/win/485/step_6.txt">http://45.33.8.238/win/485/step_6.txt</a><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 14, 2019 at 6:25 PM Jian Cai via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: jcai19<br>
Date: Mon Oct 14 15:28:03 2019<br>
New Revision: 374834<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=374834&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=374834&view=rev</a><br>
Log:<br>
Add support to -Wa,-W in clang<br>
<br>
Summary:<br>
Currently clang does not support -Wa,-W, which suppresses warning<br>
messages in GNU assembler. Add this option for gcc compatibility.<br>
<a href="https://bugs.llvm.org/show_bug.cgi?id=43651" rel="noreferrer" target="_blank">https://bugs.llvm.org/show_bug.cgi?id=43651</a>. Reland with differential<br>
information.<br>
<br>
Reviewers: bcain<br>
<br>
Reviewed By: bcain<br>
<br>
Subscribers: george.burgess.iv, gbiv, llozano, manojgupta, nickdesaulniers, cfe-commits<br>
<br>
Tags: #clang<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D68884" rel="noreferrer" target="_blank">https://reviews.llvm.org/D68884</a><br>
<br>
Added:<br>
    cfe/trunk/test/Driver/as-w-option.c<br>
Modified:<br>
    cfe/trunk/lib/Driver/ToolChains/Clang.cpp<br>
<br>
Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Clang.cpp?rev=374834&r1=374833&r2=374834&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Clang.cpp?rev=374834&r1=374833&r2=374834&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Driver/ToolChains/Clang.cpp (original)<br>
+++ cfe/trunk/lib/Driver/ToolChains/Clang.cpp Mon Oct 14 15:28:03 2019<br>
@@ -2140,7 +2140,7 @@ static void CollectArgsForIntegratedAsse<br>
         CmdArgs.push_back("-msave-temp-labels");<br>
       } else if (Value == "--fatal-warnings") {<br>
         CmdArgs.push_back("-massembler-fatal-warnings");<br>
-      } else if (Value == "--no-warn") {<br>
+      } else if (Value == "--no-warn" || Value == "-W") {<br>
         CmdArgs.push_back("-massembler-no-warn");<br>
       } else if (Value == "--noexecstack") {<br>
         UseNoExecStack = true;<br>
<br>
Added: cfe/trunk/test/Driver/as-w-option.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/as-w-option.c?rev=374834&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/as-w-option.c?rev=374834&view=auto</a><br>
==============================================================================<br>
--- cfe/trunk/test/Driver/as-w-option.c (added)<br>
+++ cfe/trunk/test/Driver/as-w-option.c Mon Oct 14 15:28:03 2019<br>
@@ -0,0 +1,14 @@<br>
+// RUN: %clang -### %s -c -o tmp.o -fno-integrated-as -Wa,-W 2>&1 | FileCheck -check-prefix=CHECK-NOIAS %s<br>
+// RUN: %clang -### %s -c -o tmp.o -integrated-as -Wa,-W 2>&1 | FileCheck -check-prefix=CHECK-IAS %s<br>
+// RUN: %clang %s -c -o %t.o -integrated-as -Wa,-W 2>&1 | FileCheck -allow-empty --check-prefix=CHECK-AS-NOWARN %s<br>
+// RUN: %clang %s -c -o %t.o -fno-integrated-as -Wa,-W 2>&1 | FileCheck -allow-empty --check-prefix=CHECK-AS-NOWARN %s<br>
+// RUN: not %clang %s -c -o %t.o -integrated-as -Wa,--fatal-warnings 2>&1 | FileCheck --check-prefix=CHECK-AS-FATAL %s<br>
+// RUN: not %clang %s -c -o %t.o -fno-integrated-as -Wa,--fatal-warnings 2>&1 | FileCheck --check-prefix=CHECK-AS-FATAL %s<br>
+<br>
+// CHECK-IAS: "-cc1" {{.*}} "-massembler-no-warn"<br>
+// CHECK-NOIAS: "-W"<br>
+// CHECK-AS-NOWARN-NOT: warning:<br>
+// CHECK-AS-FATAL-NOT: warning:<br>
+// CHECK-AS-FATAL: error<br>
+<br>
+__asm(".warning");<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>