<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Thanks for the fix!<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Oct 8, 2019, at 12:06 PM, Nico Weber <<a href="mailto:thakis@chromium.org" class="">thakis@chromium.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Almost: <a href="http://45.33.8.238/win/78/step_6.txt" class="">http://45.33.8.238/win/78/step_6.txt</a><div class=""><br class=""></div><div class="">C:\src\llvm-project\clang\test\CodeGen\ubsan-blacklist-vfs.c:11:25: error: INVALID-MAPPED-FILE: expected string not found in input<br class="">// INVALID-MAPPED-FILE: invalid-virtual-file.blacklist': No such file or directory<br class=""> ^<br class=""><stdin>:1:1: note: scanning from here<br class="">fatal error: error in backend: can't open file 'C:/src/llvm-project/out/gn/obj/clang/test/CodeGen/Output/invalid-virtual-file.blacklist': no such file or directory<br class=""><br class=""></div><div class=""><br class=""></div><div class="">Looks like it expects a "No such file" with a capital "No" but gets a "no such file" with a lower-case n. {{[Nn]}}o probably fixes this.</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 8, 2019 at 2:10 PM Jan Korous via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: jkorous<br class="">
Date: Tue Oct 8 11:13:04 2019<br class="">
New Revision: 374098<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=374098&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=374098&view=rev</a><br class="">
Log:<br class="">
[NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows<br class="">
<br class="">
Previously disabled in d0c2d5daa3e<br class="">
<br class="">
Modified:<br class="">
cfe/trunk/test/CodeGen/ubsan-blacklist-vfs.c<br class="">
<br class="">
Modified: cfe/trunk/test/CodeGen/ubsan-blacklist-vfs.c<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/ubsan-blacklist-vfs.c?rev=374098&r1=374097&r2=374098&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/ubsan-blacklist-vfs.c?rev=374098&r1=374097&r2=374098&view=diff</a><br class="">
==============================================================================<br class="">
--- cfe/trunk/test/CodeGen/ubsan-blacklist-vfs.c (original)<br class="">
+++ cfe/trunk/test/CodeGen/ubsan-blacklist-vfs.c Tue Oct 8 11:13:04 2019<br class="">
@@ -1,5 +1,3 @@<br class="">
-// UNSUPPORTED: system-windows<br class="">
-<br class="">
// Verify ubsan doesn't emit checks for blacklisted functions and files<br class="">
// RUN: echo "fun:hash" > %t-func.blacklist<br class="">
// RUN: echo "src:%s" | sed -e 's/\\/\\\\/g' > %t-file.blacklist<br class="">
@@ -7,9 +5,9 @@<br class="">
// RUN: rm -f %t-vfsoverlay.yaml<br class="">
// RUN: rm -f %t-nonexistent.blacklist<br class="">
// RUN: sed -e "s|@DIR@|%/T|g" %S/Inputs/sanitizer-blacklist-vfsoverlay.yaml | sed -e "s|@REAL_FILE@|%/t-func.blacklist|g" | sed -e "s|@NONEXISTENT_FILE@|%/t-nonexistent.blacklist|g" > %t-vfsoverlay.yaml<br class="">
-// RUN: %clang_cc1 -fsanitize=unsigned-integer-overflow -ivfsoverlay %t-vfsoverlay.yaml -fsanitize-blacklist=%T/only-virtual-file.blacklist -emit-llvm %s -o - | FileCheck %s --check-prefix=FUNC<br class="">
+// RUN: %clang_cc1 -fsanitize=unsigned-integer-overflow -ivfsoverlay %t-vfsoverlay.yaml -fsanitize-blacklist=%/T/only-virtual-file.blacklist -emit-llvm %s -o - | FileCheck %s --check-prefix=FUNC<br class="">
<br class="">
-// RUN: not %clang_cc1 -fsanitize=unsigned-integer-overflow -ivfsoverlay %t-vfsoverlay.yaml -fsanitize-blacklist=%T/invalid-virtual-file.blacklist -emit-llvm %s -o - 2>&1 | FileCheck %s --check-prefix=INVALID-MAPPED-FILE<br class="">
+// RUN: not %clang_cc1 -fsanitize=unsigned-integer-overflow -ivfsoverlay %t-vfsoverlay.yaml -fsanitize-blacklist=%/T/invalid-virtual-file.blacklist -emit-llvm %s -o - 2>&1 | FileCheck %s --check-prefix=INVALID-MAPPED-FILE<br class="">
// INVALID-MAPPED-FILE: invalid-virtual-file.blacklist': No such file or directory<br class="">
<br class="">
// RUN: not %clang_cc1 -fsanitize=unsigned-integer-overflow -ivfsoverlay %t-vfsoverlay.yaml -fsanitize-blacklist=%t-nonexistent.blacklist -emit-llvm %s -o - 2>&1 | FileCheck %s --check-prefix=INVALID<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></body></html>