<div dir="ltr">This breaks emaCXX/warn-sign-conversion.cpp -- but see other thread, maybe just revert this for now until we know what we want to do here :)</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 1, 2019 at 2:10 PM David Bolvansky via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: xbolva00<br>
Date: Tue Oct  1 11:12:13 2019<br>
New Revision: 373371<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=373371&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=373371&view=rev</a><br>
Log:<br>
[Diagnostics] Make -Wenum-compare-conditional off by default<br>
<br>
Too many false positives, eg. in Chromium.<br>
<br>
Modified:<br>
    cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br>
    cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
    cfe/trunk/test/Sema/warn-conditional-emum-types-mismatch.c<br>
<br>
Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=373371&r1=373370&r2=373371&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=373371&r1=373370&r2=373371&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original)<br>
+++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Tue Oct  1 11:12:13 2019<br>
@@ -565,7 +565,7 @@ def SwitchEnum     : DiagGroup<"switch-e<br>
 def Switch         : DiagGroup<"switch">;<br>
 def EnumCompareConditional : DiagGroup<"enum-compare-conditional">;<br>
 def EnumCompareSwitch : DiagGroup<"enum-compare-switch">;<br>
-def EnumCompare       : DiagGroup<"enum-compare", [EnumCompareConditional, EnumCompareSwitch]>;<br>
+def EnumCompare       : DiagGroup<"enum-compare", [EnumCompareSwitch]>;<br>
 def ImplicitFallthroughPerFunction :<br>
   DiagGroup<"implicit-fallthrough-per-function">;<br>
 def ImplicitFallthrough  : DiagGroup<"implicit-fallthrough",<br>
<br>
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=373371&r1=373370&r2=373371&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=373371&r1=373370&r2=373371&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)<br>
+++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Tue Oct  1 11:12:13 2019<br>
@@ -6172,7 +6172,7 @@ def warn_comparison_of_mixed_enum_types<br>
 def warn_conditional_mixed_enum_types : Warning<<br>
   "enumeration type mismatch in conditional expression"<br>
   "%diff{ ($ and $)|}0,1">,<br>
-  InGroup<EnumCompareConditional>;<br>
+  InGroup<EnumCompareConditional>, DefaultIgnore;<br>
 def warn_comparison_of_mixed_enum_types_switch : Warning<<br>
   "comparison of two values with different enumeration types in switch statement"<br>
   "%diff{ ($ and $)|}0,1">,<br>
<br>
Modified: cfe/trunk/test/Sema/warn-conditional-emum-types-mismatch.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/warn-conditional-emum-types-mismatch.c?rev=373371&r1=373370&r2=373371&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/warn-conditional-emum-types-mismatch.c?rev=373371&r1=373370&r2=373371&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Sema/warn-conditional-emum-types-mismatch.c (original)<br>
+++ cfe/trunk/test/Sema/warn-conditional-emum-types-mismatch.c Tue Oct  1 11:12:13 2019<br>
@@ -1,9 +1,5 @@<br>
 // RUN: %clang_cc1 -x c -fsyntax-only -verify -Wenum-compare-conditional %s<br>
-// RUN: %clang_cc1 -x c -fsyntax-only -verify -Wenum-compare %s<br>
-// RUN: %clang_cc1 -x c -fsyntax-only -verify  %s<br>
 // RUN: %clang_cc1 -x c++ -fsyntax-only -verify -Wenum-compare-conditional %s<br>
-// RUN: %clang_cc1 -x c++ -fsyntax-only -verify -Wenum-compare %s<br>
-// RUN: %clang_cc1 -x c++ -fsyntax-only -verify %s<br>
<br>
 enum ro { A = 0x10 };<br>
 enum rw { B = 0xFF };<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>