<div dir="ltr">Nitpick (sorry): I think common style for commit message is to describe what the change does in present tense, i.e. ""Mark a bunch of classes 'final'".</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Aug 29, 2019 at 6:15 AM Dmitri Gribenko via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: gribozavr<br>
Date: Thu Aug 29 03:16:41 2019<br>
New Revision: 370321<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=370321&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=370321&view=rev</a><br>
Log:<br>
[Index] Marked a bunch of classes 'final'<br>
<br>
This file defines multiple inheritance hierarchies and 'final' helps<br>
with readability.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Index/IndexingAction.cpp<br>
<br>
Modified: cfe/trunk/lib/Index/IndexingAction.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Index/IndexingAction.cpp?rev=370321&r1=370320&r2=370321&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Index/IndexingAction.cpp?rev=370321&r1=370320&r2=370321&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Index/IndexingAction.cpp (original)<br>
+++ cfe/trunk/lib/Index/IndexingAction.cpp Thu Aug 29 03:16:41 2019<br>
@@ -23,7 +23,7 @@ using namespace clang::index;<br>
<br>
 namespace {<br>
<br>
-class IndexASTConsumer : public ASTConsumer {<br>
+class IndexASTConsumer final : public ASTConsumer {<br>
   std::shared_ptr<Preprocessor> PP;<br>
   std::shared_ptr<IndexingContext> IndexCtx;<br>
<br>
@@ -55,7 +55,7 @@ protected:<br>
   }<br>
 };<br>
<br>
-class IndexPPCallbacks : public PPCallbacks {<br>
+class IndexPPCallbacks final : public PPCallbacks {<br>
   std::shared_ptr<IndexingContext> IndexCtx;<br>
<br>
 public:<br>
@@ -110,7 +110,7 @@ protected:<br>
   }<br>
 };<br>
<br>
-class IndexAction : public ASTFrontendAction, IndexActionBase {<br>
+class IndexAction final : public ASTFrontendAction, IndexActionBase {<br>
 public:<br>
   IndexAction(std::shared_ptr<IndexDataConsumer> DataConsumer,<br>
               IndexingOptions Opts)<br>
@@ -133,7 +133,7 @@ protected:<br>
   }<br>
 };<br>
<br>
-class WrappingIndexAction : public WrapperFrontendAction, IndexActionBase {<br>
+class WrappingIndexAction final : public WrapperFrontendAction, IndexActionBase {<br>
   bool IndexActionFailed = false;<br>
<br>
 public:<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>