<div dir="ltr">fixed with r369992</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 26, 2019 at 1:16 PM Vitaly Buka <<a href="mailto:vitalybuka@google.com">vitalybuka@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Thank for the try, but it's not the fix as it just disabled the test everywhere as no one sets "assertions".</div><div>Also I am not sure how the patch can break the test, it just renamed the files. Which bot was that?<br></div><div>Is it possible that your local checkout just had the test disabled?</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Aug 24, 2019 at 1:12 AM David Zarzycki <<a href="mailto:dave@znu.io" target="_blank">dave@znu.io</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Fix: r369843<br>
<br>
Please confirm. Thanks!<br>
<br>
> On Aug 24, 2019, at 8:18 AM, David Zarzycki <<a href="mailto:dave@znu.io" target="_blank">dave@znu.io</a>> wrote:<br>
> <br>
> This seems to have broken building on Red Hat Fedora Linux 30 (x86_64). Was this expected?<br>
> <br>
> FAIL: Clang :: CodeGenCXX/lifetime-sanitizer.cpp (7750 of 50751)<br>
> ******************** TEST 'Clang :: CodeGenCXX/lifetime-sanitizer.cpp' FAILED ********************<br>
> Script:<br>
> --<br>
> : 'RUN: at line 1';   /tmp/_update_lc/r/bin/clang -w -target x86_64-linux-gnu -S -emit-llvm -o - -fno-exceptions -O0 /home/dave/s/lp/clang/test/CodeGenCXX/lifetime-sanitizer.cpp |       /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/clang/test/CodeGenCXX/lifetime-sanitizer.cpp -check-prefixes=CHECK,CHECK-O0 --implicit-check-not=llvm.lifetime<br>
> : 'RUN: at line 3';   /tmp/_update_lc/r/bin/clang -w -target x86_64-linux-gnu -S -emit-llvm -o - -fno-exceptions -O0      -fsanitize=address -fsanitize-address-use-after-scope /home/dave/s/lp/clang/test/CodeGenCXX/lifetime-sanitizer.cpp |      /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/clang/test/CodeGenCXX/lifetime-sanitizer.cpp -check-prefixes=CHECK,LIFETIME<br>
> --<br>
> Exit Code: 1<br>
> <br>
> Command Output (stderr):<br>
> --<br>
> /home/dave/s/lp/clang/test/CodeGenCXX/lifetime-sanitizer.cpp:30:18: error: CHECK-LABEL: expected string not found in input<br>
> // CHECK-LABEL: cond.true:<br>
>                 ^<br>
> <stdin>:21:8: note: scanning from here<br>
> br i1 %7, label %8, label %10<br>
>       ^<br>
> <stdin>:25:6: note: possible intended match here<br>
> store i1 true, i1* %4, align 1<br>
>     ^<br>
> <br>
> <br>
> <br>
>> On Aug 24, 2019, at 2:31 AM, Vitaly Buka via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
>> <br>
>> Author: vitalybuka<br>
>> Date: Fri Aug 23 18:31:38 2019<br>
>> New Revision: 369830<br>
>> <br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=369830&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=369830&view=rev</a><br>
>> Log:<br>
>> NFC: Rename some sanitizer related lifetime checks<br>
>> <br>
>> Added:<br>
>>   cfe/trunk/test/CodeGen/lifetime-sanitizer.c<br>
>>   cfe/trunk/test/CodeGenCXX/lifetime-sanitizer.cpp<br>
>> Removed:<br>
>>   cfe/trunk/test/CodeGen/lifetime-asan.c<br>
>>   cfe/trunk/test/CodeGenCXX/lifetime-asan.cpp<br>
>> <br>
>> Removed: cfe/trunk/test/CodeGen/lifetime-asan.c<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/lifetime-asan.c?rev=369829&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/lifetime-asan.c?rev=369829&view=auto</a><br>
>> ==============================================================================<br>
>> --- cfe/trunk/test/CodeGen/lifetime-asan.c (original)<br>
>> +++ cfe/trunk/test/CodeGen/lifetime-asan.c (removed)<br>
>> @@ -1,21 +0,0 @@<br>
>> -// RUN: %clang -target x86_64-linux-gnu -S -emit-llvm -o - -O0 %s | FileCheck %s -check-prefix=CHECK-O0<br>
>> -// RUN: %clang -target x86_64-linux-gnu -S -emit-llvm -o - -O0 \<br>
>> -// RUN:     -fsanitize=address -fsanitize-address-use-after-scope %s | \<br>
>> -// RUN:     FileCheck %s -check-prefix=CHECK-ASAN-USE-AFTER-SCOPE<br>
>> -<br>
>> -extern int bar(char *A, int n);<br>
>> -<br>
>> -// CHECK-O0-NOT: @llvm.lifetime.start<br>
>> -int foo(int n) {<br>
>> -  if (n) {<br>
>> -    // CHECK-ASAN-USE-AFTER-SCOPE: @llvm.lifetime.start.p0i8(i64 10, i8* {{.*}})<br>
>> -    char A[10];<br>
>> -    return bar(A, 1);<br>
>> -    // CHECK-ASAN-USE-AFTER-SCOPE: @llvm.lifetime.end.p0i8(i64 10, i8* {{.*}})<br>
>> -  } else {<br>
>> -    // CHECK-ASAN-USE-AFTER-SCOPE: @llvm.lifetime.start.p0i8(i64 20, i8* {{.*}})<br>
>> -    char A[20];<br>
>> -    return bar(A, 2);<br>
>> -    // CHECK-ASAN-USE-AFTER-SCOPE: @llvm.lifetime.end.p0i8(i64 20, i8* {{.*}})<br>
>> -  }<br>
>> -}<br>
>> <br>
>> Added: cfe/trunk/test/CodeGen/lifetime-sanitizer.c<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/lifetime-sanitizer.c?rev=369830&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/lifetime-sanitizer.c?rev=369830&view=auto</a><br>
>> ==============================================================================<br>
>> --- cfe/trunk/test/CodeGen/lifetime-sanitizer.c (added)<br>
>> +++ cfe/trunk/test/CodeGen/lifetime-sanitizer.c Fri Aug 23 18:31:38 2019<br>
>> @@ -0,0 +1,21 @@<br>
>> +// RUN: %clang -target x86_64-linux-gnu -S -emit-llvm -o - -O0 %s | FileCheck %s -check-prefix=CHECK-O0<br>
>> +// RUN: %clang -target x86_64-linux-gnu -S -emit-llvm -o - -O0 \<br>
>> +// RUN:     -fsanitize=address -fsanitize-address-use-after-scope %s | \<br>
>> +// RUN:     FileCheck %s -check-prefix=LIFETIME<br>
>> +<br>
>> +extern int bar(char *A, int n);<br>
>> +<br>
>> +// CHECK-O0-NOT: @llvm.lifetime.start<br>
>> +int foo(int n) {<br>
>> +  if (n) {<br>
>> +    // LIFETIME: @llvm.lifetime.start.p0i8(i64 10, i8* {{.*}})<br>
>> +    char A[10];<br>
>> +    return bar(A, 1);<br>
>> +    // LIFETIME: @llvm.lifetime.end.p0i8(i64 10, i8* {{.*}})<br>
>> +  } else {<br>
>> +    // LIFETIME: @llvm.lifetime.start.p0i8(i64 20, i8* {{.*}})<br>
>> +    char A[20];<br>
>> +    return bar(A, 2);<br>
>> +    // LIFETIME: @llvm.lifetime.end.p0i8(i64 20, i8* {{.*}})<br>
>> +  }<br>
>> +}<br>
>> <br>
>> Removed: cfe/trunk/test/CodeGenCXX/lifetime-asan.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/lifetime-asan.cpp?rev=369829&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/lifetime-asan.cpp?rev=369829&view=auto</a><br>
>> ==============================================================================<br>
>> --- cfe/trunk/test/CodeGenCXX/lifetime-asan.cpp (original)<br>
>> +++ cfe/trunk/test/CodeGenCXX/lifetime-asan.cpp (removed)<br>
>> @@ -1,42 +0,0 @@<br>
>> -// RUN: %clang -target x86_64-linux-gnu -S -emit-llvm -o - -fno-exceptions -O0 %s | FileCheck %s -check-prefixes=CHECK,CHECK-O0 --implicit-check-not=llvm.lifetime<br>
>> -// RUN: %clang -target x86_64-linux-gnu -S -emit-llvm -o - -fno-exceptions -O0 \<br>
>> -// RUN:     -fsanitize=address -fsanitize-address-use-after-scope %s | \<br>
>> -// RUN:     FileCheck %s -check-prefixes=CHECK,CHECK-ASAN-USE-AFTER-SCOPE<br>
>> -<br>
>> -extern int bar(char *A, int n);<br>
>> -<br>
>> -struct X { X(); ~X(); int *p; };<br>
>> -struct Y { Y(); int *p; };<br>
>> -<br>
>> -extern "C" void a(), b(), c(), d();<br>
>> -<br>
>> -// CHECK-LABEL: @_Z3foo<br>
>> -void foo(int n) {<br>
>> -  // CHECK: call void @a()<br>
>> -  a();<br>
>> -<br>
>> -  // CHECK: call void @b()<br>
>> -  // CHECK-ASAN-USE-AFTER-SCOPE: store i1 false<br>
>> -  // CHECK-ASAN-USE-AFTER-SCOPE: store i1 false<br>
>> -  // CHECK: br i1<br>
>> -  //<br>
>> -  // CHECK-ASAN-USE-AFTER-SCOPE: @llvm.lifetime.start<br>
>> -  // CHECK-ASAN-USE-AFTER-SCOPE: store i1 true<br>
>> -  // CHECK: call void @_ZN1XC<br>
>> -  // CHECK: br label<br>
>> -  //<br>
>> -  // CHECK-ASAN-USE-AFTER-SCOPE: @llvm.lifetime.start<br>
>> -  // CHECK-ASAN-USE-AFTER-SCOPE: store i1 true<br>
>> -  // CHECK: call void @_ZN1YC<br>
>> -  // CHECK: br label<br>
>> -  //<br>
>> -  // CHECK: call void @c()<br>
>> -  // CHECK-ASAN-USE-AFTER-SCOPE: br i1<br>
>> -  // CHECK-ASAN-USE-AFTER-SCOPE: @llvm.lifetime.end<br>
>> -  // CHECK-ASAN-USE-AFTER-SCOPE: br i1<br>
>> -  // CHECK-ASAN-USE-AFTER-SCOPE: @llvm.lifetime.end<br>
>> -  b(), (n ? X().p : Y().p), c();<br>
>> -<br>
>> -  // CHECK: call void @d()<br>
>> -  d();<br>
>> -}<br>
>> <br>
>> Added: cfe/trunk/test/CodeGenCXX/lifetime-sanitizer.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/lifetime-sanitizer.cpp?rev=369830&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/lifetime-sanitizer.cpp?rev=369830&view=auto</a><br>
>> ==============================================================================<br>
>> --- cfe/trunk/test/CodeGenCXX/lifetime-sanitizer.cpp (added)<br>
>> +++ cfe/trunk/test/CodeGenCXX/lifetime-sanitizer.cpp Fri Aug 23 18:31:38 2019<br>
>> @@ -0,0 +1,50 @@<br>
>> +// RUN: %clang -w -target x86_64-linux-gnu -S -emit-llvm -o - -fno-exceptions -O0 %s | \<br>
>> +// RUN:      FileCheck %s -check-prefixes=CHECK,CHECK-O0 --implicit-check-not=llvm.lifetime<br>
>> +// RUN: %clang -w -target x86_64-linux-gnu -S -emit-llvm -o - -fno-exceptions -O0 \<br>
>> +// RUN:     -fsanitize=address -fsanitize-address-use-after-scope %s | \<br>
>> +// RUN:     FileCheck %s -check-prefixes=CHECK,LIFETIME<br>
>> +<br>
>> +extern int bar(char *A, int n);<br>
>> +<br>
>> +struct X {<br>
>> +  X();<br>
>> +  ~X();<br>
>> +  int *p;<br>
>> +};<br>
>> +struct Y {<br>
>> +  Y();<br>
>> +  int *p;<br>
>> +};<br>
>> +<br>
>> +extern "C" void a(), b(), c(), d();<br>
>> +<br>
>> +// CHECK-LABEL: @_Z3foo<br>
>> +void foo(int n) {<br>
>> +  // CHECK-LABEL: call void @a()<br>
>> +  a();<br>
>> +<br>
>> +  // CHECK-LABEL: call void @b()<br>
>> +  // CHECK: store i1 false<br>
>> +  // CHECK-LABEL: br i1<br>
>> +  //<br>
>> +  // CHECK-LABEL: cond.true:<br>
>> +  // LIFETIME: @llvm.lifetime.start<br>
>> +  // LIFETIME: store i1 true<br>
>> +  // LIFETIME: call void @_ZN1XC<br>
>> +  // CHECK-LABEL: br label<br>
>> +  //<br>
>> +  // CHECK-LABEL: cond.false:<br>
>> +  // LIFETIME: @llvm.lifetime.start<br>
>> +  // LIFETIME: store i1 true<br>
>> +  // LIFETIME: call void @_ZN1YC<br>
>> +  // CHECK-LABEL: br label<br>
>> +  //<br>
>> +  // CHECK-LABEL: cond.end:<br>
>> +  // CHECK: call void @c()<br>
>> +  // LIFETIME: @llvm.lifetime.end<br>
>> +  // LIFETIME: @llvm.lifetime.end<br>
>> +  b(), (n ? X().p : Y().p), c();<br>
>> +<br>
>> +  // CHECK: call void @d()<br>
>> +  d();<br>
>> +}<br>
>> <br>
>> <br>
>> _______________________________________________<br>
>> cfe-commits mailing list<br>
>> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
>> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
> <br>
<br>
</blockquote></div>
</blockquote></div>