<div dir="ltr">Hello Kristof,<br><br>This commit broke test to few builders:<br><br><a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/53703">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/53703</a><br><a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast</a><br><br>. . . <br>Failing Tests (1):<br>    Clang Tools :: clang-tidy/duplicate-reports.cpp<br><br>Please have a look ASAP?<br><br>Thanks<br><br>Galina<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Aug 23, 2019 at 7:56 AM Kristof Umann via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: szelethus<br>
Date: Fri Aug 23 07:57:27 2019<br>
New Revision: 369763<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=369763&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=369763&view=rev</a><br>
Log:<br>
[clang-tidy] Possibility of displaying duplicate warnings<br>
<br>
Summary: In case a checker is registered multiple times as an alias, the emitted warnings are uniqued by the report message. However, it is random which checker name is included in the warning. When processing the output of clang-tidy this behavior caused some problems. In this commit the uniquing key contains the checker name too.<br>
<br>
Reviewers: alexfh, xazax.hun, Szelethus, aaron.ballman, lebedev.ri, JonasToth, gribozavr<br>
<br>
Reviewed By: alexfh<br>
<br>
Subscribers: dkrupp, whisperity, rnkovacs, mgrang, cfe-commits<br>
<br>
Patch by Tibor Brunner!<br>
<br>
Tags: #clang<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D65065" rel="noreferrer" target="_blank">https://reviews.llvm.org/D65065</a><br>
<br>
Added:<br>
    clang-tools-extra/trunk/test/clang-tidy/duplicate-reports.cpp<br>
Modified:<br>
    clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp<br>
<br>
Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp?rev=369763&r1=369762&r2=369763&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp?rev=369763&r1=369762&r2=369763&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp (original)<br>
+++ clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp Fri Aug 23 07:57:27 2019<br>
@@ -742,8 +742,9 @@ struct LessClangTidyError {<br>
     const tooling::DiagnosticMessage &M1 = LHS.Message;<br>
     const tooling::DiagnosticMessage &M2 = RHS.Message;<br>
<br>
-    return std::tie(M1.FilePath, M1.FileOffset, M1.Message) <<br>
-           std::tie(M2.FilePath, M2.FileOffset, M2.Message);<br>
+    return<br>
+      std::tie(M1.FilePath, M1.FileOffset, LHS.DiagnosticName, M1.Message) <<br>
+      std::tie(M2.FilePath, M2.FileOffset, RHS.DiagnosticName, M2.Message);<br>
   }<br>
 };<br>
 struct EqualClangTidyError {<br>
<br>
Added: clang-tools-extra/trunk/test/clang-tidy/duplicate-reports.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/duplicate-reports.cpp?rev=369763&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/duplicate-reports.cpp?rev=369763&view=auto</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/test/clang-tidy/duplicate-reports.cpp (added)<br>
+++ clang-tools-extra/trunk/test/clang-tidy/duplicate-reports.cpp Fri Aug 23 07:57:27 2019<br>
@@ -0,0 +1,15 @@<br>
+// RUN: %check_clang_tidy %s cert-err09-cpp,cert-err61-cpp %t<br>
+<br>
+void alwaysThrows() {<br>
+  int ex = 42;<br>
+  // CHECK-MESSAGES: warning: throw expression should throw anonymous temporary values instead [cert-err09-cpp]<br>
+  // CHECK-MESSAGES: warning: throw expression should throw anonymous temporary values instead [cert-err61-cpp]<br>
+  throw ex;<br>
+}<br>
+<br>
+void doTheJob() {<br>
+  try {<br>
+    alwaysThrows();<br>
+  } catch (int&) {<br>
+  }<br>
+}<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>