<div dir="ltr">Up to you :)</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Aug 9, 2019 at 8:54 PM Gábor Horváth <<a href="mailto:xazax.hun@gmail.com">xazax.hun@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">It does! Do you want me to commit that test as well?<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 9 Aug 2019 at 17:50, Nico Weber <<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">This fixes `+ X(std::unique_ptr<int> up) : pointee(up.get()), pointer(std::move(up)) {}` as well, right?<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Aug 9, 2019 at 8:31 PM Gabor Horvath via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: xazax<br>
Date: Fri Aug 9 17:32:29 2019<br>
New Revision: 368501<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=368501&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=368501&view=rev</a><br>
Log:<br>
Fix a false positive warning when initializing members with gsl::Owners.<br>
<br>
Modified:<br>
cfe/trunk/lib/Sema/SemaInit.cpp<br>
cfe/trunk/test/Sema/warn-lifetime-analysis-nocfg.cpp<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaInit.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaInit.cpp?rev=368501&r1=368500&r2=368501&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaInit.cpp?rev=368501&r1=368500&r2=368501&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaInit.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaInit.cpp Fri Aug 9 17:32:29 2019<br>
@@ -7217,6 +7217,11 @@ void Sema::checkInitializerLifetime(cons<br>
if (pathContainsInit(Path))<br>
return false;<br>
<br>
+ // Suppress false positives for code like the below:<br>
+ // Ctor(unique_ptr<T> up) : member(*up), member2(move(up)) {}<br>
+ if (IsLocalGslOwner && pathOnlyInitializesGslPointer(Path))<br>
+ return false;<br>
+<br>
auto *DRE = dyn_cast<DeclRefExpr>(L);<br>
auto *VD = DRE ? dyn_cast<VarDecl>(DRE->getDecl()) : nullptr;<br>
if (!VD) {<br>
<br>
Modified: cfe/trunk/test/Sema/warn-lifetime-analysis-nocfg.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/warn-lifetime-analysis-nocfg.cpp?rev=368501&r1=368500&r2=368501&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/warn-lifetime-analysis-nocfg.cpp?rev=368501&r1=368500&r2=368501&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Sema/warn-lifetime-analysis-nocfg.cpp (original)<br>
+++ cfe/trunk/test/Sema/warn-lifetime-analysis-nocfg.cpp Fri Aug 9 17:32:29 2019<br>
@@ -120,6 +120,13 @@ void initLocalGslPtrWithTempOwner() {<br>
}<br>
<br>
namespace std {<br>
+template<class T> struct remove_reference { typedef T type; };<br>
+template<class T> struct remove_reference<T &> { typedef T type; };<br>
+template<class T> struct remove_reference<T &&> { typedef T type; };<br>
+<br>
+template<class T><br>
+typename remove_reference<T>::type &&move(T &&t) noexcept;<br>
+<br>
template <typename T><br>
struct basic_iterator {<br>
basic_iterator operator++();<br>
@@ -153,6 +160,7 @@ struct basic_string {<br>
<br>
template<typename T><br>
struct unique_ptr {<br>
+ T &operator*();<br>
T *get() const;<br>
};<br>
<br>
@@ -217,3 +225,10 @@ int &doNotFollowReferencesForLocalOwner(<br>
const char *trackThroughMultiplePointer() {<br>
return std::basic_string_view<char>(std::basic_string<char>()).begin(); // expected-warning {{returning address of local temporary object}}<br>
}<br>
+<br>
+struct X {<br>
+ X(std::unique_ptr<int> up) : pointee(*up), pointer(std::move(up)) {}<br>
+<br>
+ int &pointee;<br>
+ std::unique_ptr<int> pointer;<br>
+};<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</blockquote></div>
</blockquote></div>