<div dir="ltr">Let me know if the problem persists after r368475. Someone else filed 

<a href="https://bugs.llvm.org/show_bug.cgi?id=42948">https://bugs.llvm.org/show_bug.cgi?id=42948</a> as well.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Aug 8, 2019 at 11:34 PM Martin Storsjö <<a href="mailto:martin@martin.st">martin@martin.st</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This change broke compiling Qt.<br>
<br>
A repro case looks like this:<br>
<br>
mkdir -p fake-qtincl/5.13.1/QtCore/private<br>
touch fake-qtincl/5.13.1/QtCore/private/qglobal_p.h<br>
touch fake-qtincl/QtCore <br>
echo "#include <QtCore/private/qglobal_p.h>" > qtincl.cpp<br>
bin/clang++ -c qtincl.cpp -Ifake-qtincl -Ifake-qtincl/5.13.1<br>
<br>
Previously this ignored the non-directory QtCore, but now clang bails out <br>
on it. (And this is code that all other major compilers tolerate, afaik.)<br>
<br>
// Martin<br>
<br>
<br>
On Thu, 8 Aug 2019, Reid Kleckner via cfe-commits wrote:<br>
<br>
> Author: rnk<br>
> Date: Thu Aug  8 14:35:03 2019<br>
> New Revision: 368348<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=368348&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=368348&view=rev</a><br>
> Log:<br>
> Fix up fd limit diagnosis code<br>
><br>
> Apparently Windows returns the "invalid argument" error code when the<br>
> path contains invalid characters such as '<'. The<br>
> test/Preprocessor/include-likely-typo.c test does this, so it was<br>
> failing after r368322.<br>
><br>
> Also, the diagnostic requires two arguments, so add the filename.<br>
><br>
> Modified:<br>
>    cfe/trunk/lib/Lex/HeaderSearch.cpp<br>
><br>
> Modified: cfe/trunk/lib/Lex/HeaderSearch.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/HeaderSearch.cpp?rev=368348&r1=368347&r2=368348&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/HeaderSearch.cpp?rev=368348&r1=368347&r2=368348&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/Lex/HeaderSearch.cpp (original)<br>
> +++ cfe/trunk/lib/Lex/HeaderSearch.cpp Thu Aug  8 14:35:03 2019<br>
> @@ -316,8 +316,9 @@ const FileEntry *HeaderSearch::getFileAn<br>
>     // message.<br>
>     std::error_code EC = File.getError();<br>
>     if (EC != std::errc::no_such_file_or_directory &&<br>
> -        EC != std::errc::is_a_directory) {<br>
> -      Diags.Report(IncludeLoc, diag::err_cannot_open_file) << EC.message();<br>
> +        EC != std::errc::invalid_argument && EC != std::errc::is_a_directory) {<br>
> +      Diags.Report(IncludeLoc, diag::err_cannot_open_file)<br>
> +          << FileName << EC.message();<br>
>     }<br>
>     return nullptr;<br>
>   }<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>