<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Ugh this is silly… fixed again.<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Aug 5, 2019, at 12:55 PM, Nico Weber <<a href="mailto:thakis@chromium.org" class="">thakis@chromium.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Still sad, now with a different message: <a href="http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/45220" class="">http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/45220</a><div class=""><br class=""></div><div class="">/home/buildbot/llvm-build-dir/clang-sphinx-docs/llvm/src/tools/clang/docs/UsersManual.rst:1002: WARNING: unknown option: -Wall<br class=""></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 5, 2019 at 3:46 PM JF Bastien <<a href="mailto:jfbastien@apple.com" class="">jfbastien@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class="">Fixed. I guess we should document those...<br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Aug 5, 2019, at 10:51 AM, Nico Weber <<a href="mailto:thakis@chromium.org" target="_blank" class="">thakis@chromium.org</a>> wrote:</div><br class="gmail-m_-7098818552491223404Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">This breaks the sphinx bot:</div><div class=""><br class=""></div><div class=""><a href="http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/45204/steps/docs-clang-html/logs/stdio" target="_blank" class="">http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/45204/steps/docs-clang-html/logs/stdio</a><br class=""></div><div class=""><br class=""></div>Warning, treated as error:<br class="">/home/buildbot/llvm-build-dir/clang-sphinx-docs/llvm/src/tools/clang/docs/UsersManual.rst:995: WARNING: unknown option: -Wno-c++98-compat<br class=""></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 5, 2019 at 12:52 PM JF Bastien via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: jfb<br class="">
Date: Mon Aug 5 09:53:45 2019<br class="">
New Revision: 367889<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=367889&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=367889&view=rev</a><br class="">
Log:<br class="">
[docs] document -Weveything more betterer<br class="">
<br class="">
Reviewers: aaron.ballman<br class="">
<br class="">
Subscribers: jkorous, dexonsmith, cfe-commits<br class="">
<br class="">
Tags: #clang<br class="">
<br class="">
Differential Revision: <a href="https://reviews.llvm.org/D65706" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D65706</a><br class="">
<br class="">
Modified:<br class="">
cfe/trunk/docs/UsersManual.rst<br class="">
<br class="">
Modified: cfe/trunk/docs/UsersManual.rst<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/UsersManual.rst?rev=367889&r1=367888&r2=367889&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/UsersManual.rst?rev=367889&r1=367888&r2=367889&view=diff</a><br class="">
==============================================================================<br class="">
--- cfe/trunk/docs/UsersManual.rst (original)<br class="">
+++ cfe/trunk/docs/UsersManual.rst Mon Aug 5 09:53:45 2019<br class="">
@@ -992,13 +992,24 @@ is treated as a system header.<br class="">
Enabling All Diagnostics<br class="">
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^<br class="">
<br class="">
-In addition to the traditional ``-W`` flags, one can enable **all**<br class="">
-diagnostics by passing :option:`-Weverything`. This works as expected<br class="">
-with<br class="">
-:option:`-Werror`, and also includes the warnings from :option:`-pedantic`.<br class="">
+In addition to the traditional ``-W`` flags, one can enable **all** diagnostics<br class="">
+by passing :option:`-Weverything`. This works as expected with<br class="">
+:option:`-Werror`, and also includes the warnings from :option:`-pedantic`. Some<br class="">
+diagnostics contradict each other, therefore, users of :option:`-Weverything`<br class="">
+often disable many diagnostics such as :option:`-Wno-c++98-compat`<br class="">
+:option:`-Wno-c++-compat` because they contradict recent C++ standards.<br class="">
<br class="">
-Note that when combined with :option:`-w` (which disables all warnings), that<br class="">
-flag wins.<br class="">
+Since :option:`-Weverything` enables every diagnostic, we generally don't<br class="">
+recommend using it. :option:`-Wall` :option:`-Wextra` are a better choice for<br class="">
+most projects. Using :option:`-Weverything` means that updating your compiler is<br class="">
+more difficult because you're exposed to experimental diagnostics which might be<br class="">
+of lower quality than the default ones. If you do use :option:`-Weverything`<br class="">
+then we advise that you address all new compiler diagnostics as they get added<br class="">
+to Clang, either by fixing everything they find or explicitly disabling that<br class="">
+diagnostic with its corresponding `Wno-` option.<br class="">
+<br class="">
+Note that when combined with :option:`-w` (which disables all warnings),<br class="">
+disabling all warnings wins.<br class="">
<br class="">
Controlling Static Analyzer Diagnostics<br class="">
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></blockquote></div>
</div></blockquote></div><br class=""></body></html>