<div dir="ltr">r367657 should fix this.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Aug 2, 2019 at 12:20 AM Rong Xu <<a href="mailto:xur@google.com">xur@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">yes. I already know this issue as this also breaks windows bolt. <div>The fix should be simple.</div><div><br></div><div>-Rong</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Aug 1, 2019 at 11:52 PM Petr Hosek via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">phosek added a comment.<br>
<br>
Looks like this change broke `Profile/gcc-flag-compatibility.c` test on macOS:<br>
<br>
  ******************** TEST 'Clang :: Profile/gcc-flag-compatibility.c' FAILED ********************<br>
  Script:<br>
  --<br>
  : 'RUN: at line 10';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -c -S -o - -emit-llvm -fprofile-generate -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-GEN /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c<br>
  : 'RUN: at line 11';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -c -S -o - -emit-llvm -fprofile-generate -fexperimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-GEN /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c<br>
  : 'RUN: at line 16';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -c -S -o - -emit-llvm -fprofile-generate=/path/to -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefixes=PROFILE-GEN,PROFILE-GEN-EQ /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c<br>
  : 'RUN: at line 22';   rm -rf /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir<br>
  : 'RUN: at line 23';   mkdir -p /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path<br>
  : 'RUN: at line 24';   llvm-profdata merge /b/s/w/ir/k/llvm-project/clang/test/Profile/Inputs/gcc-flag-compatibility.proftext -o /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/default.profdata<br>
  : 'RUN: at line 25';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -Xclang -disable-llvm-passes -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c<br>
  : 'RUN: at line 26';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -Xclang -disable-llvm-passes -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path -fexperimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c<br>
  : 'RUN: at line 30';   rm -rf /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir<br>
  : 'RUN: at line 31';   mkdir -p /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path<br>
  : 'RUN: at line 32';   llvm-profdata merge /b/s/w/ir/k/llvm-project/clang/test/Profile/Inputs/gcc-flag-compatibility.proftext -o /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof<br>
  : 'RUN: at line 33';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -Xclang -disable-llvm-passes -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c<br>
  : 'RUN: at line 34';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -Xclang -disable-llvm-passes -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof -fexperimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c<br>
  : 'RUN: at line 39';   rm -rf /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir<br>
  : 'RUN: at line 40';   mkdir -p /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path<br>
  : 'RUN: at line 41';   llvm-profdata merge /b/s/w/ir/k/llvm-project/clang/test/Profile/Inputs/gcc-flag-compatibility_IR.proftext -o /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/default.profdata<br>
  : 'RUN: at line 42';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE-IR /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c<br>
  : 'RUN: at line 43';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path -fexperimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE-IR /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c<br>
  : 'RUN: at line 47';   rm -rf /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir<br>
  : 'RUN: at line 48';   mkdir -p /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path<br>
  : 'RUN: at line 49';   llvm-profdata merge /b/s/w/ir/k/llvm-project/clang/test/Profile/Inputs/gcc-flag-compatibility_IR.proftext -o /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof<br>
  : 'RUN: at line 50';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE-IR /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c<br>
  : 'RUN: at line 51';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof -fexperimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE-IR /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c<br>
  --<br>
  Exit Code: 1<br>
<br>
  Command Output (stderr):<br>
  --<br>
  /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c:12:17: error: PROFILE-GEN: expected string not found in input<br>
  // PROFILE-GEN: @__profc_main = private global [2 x i64] zeroinitializer, section "__llvm_prf_cnts", align 8<br>
                  ^<br>
  <stdin>:1:1: note: scanning from here<br>
  ; ModuleID = '/b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c'<br>
  ^<br>
  <stdin>:9:1: note: possible intended match here<br>
  @__profc_main = private global [2 x i64] zeroinitializer, section "__DATA,__llvm_prf_cnts", align 8<br>
  ^<br>
<br>
  --<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D64029/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D64029/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D64029" rel="noreferrer" target="_blank">https://reviews.llvm.org/D64029</a><br>
<br>
<br>
<br>
</blockquote></div>
</blockquote></div>