<div dir="ltr">Looks good to me. Thanks for the fix.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Aaron Ballman <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> ezt írta (időpont: 2019. júl. 29., H, 21:06):<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, Jul 29, 2019 at 3:03 PM Galina Kistanova via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Hello Gabor ,<br>
><br>
> It looks like this commit broke tests on couple builders:<br>
><br>
> <a href="http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/18867/steps/test-check-all/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/18867/steps/test-check-all/logs/stdio</a><br>
> <a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast</a><br>
> . . .<br>
> ********************<br>
> Failing Tests (1):<br>
>     Clang :: Analysis/taint-generic.c<br>
><br>
><br>
> Please have a look?<br>
> These builders were already red and did not send any notifications.<br>
<br>
I think Reid fixed this in r367249<br>
(<a href="http://llvm.org/viewvc/llvm-project?view=revision&revision=367249" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?view=revision&revision=367249</a>).<br>
<br>
~Aaron<br>
<br>
><br>
> Thanks<br>
><br>
> Galina<br>
><br>
> On Sun, Jul 28, 2019 at 8:00 AM Gabor Borsik via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>> Author: boga95<br>
>> Date: Sun Jul 28 07:57:41 2019<br>
>> New Revision: 367193<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=367193&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=367193&view=rev</a><br>
>> Log:<br>
>> Buildbot fix for r367190<br>
>><br>
>> Modified:<br>
>>     cfe/trunk/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp<br>
>><br>
>> Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp?rev=367193&r1=367192&r2=367193&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp?rev=367193&r1=367192&r2=367193&view=diff</a><br>
>> ==============================================================================<br>
>> --- cfe/trunk/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp (original)<br>
>> +++ cfe/trunk/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp Sun Jul 28 07:57:41 2019<br>
>> @@ -811,7 +811,7 @@ void ento::registerGenericTaintChecker(C<br>
>>    llvm::Optional<TaintConfig> Config =<br>
>>        getConfiguration<TaintConfig>(Mgr, Checker, Option, ConfigFile);<br>
>>    if (Config)<br>
>> -    Checker->parseConfiguration(Mgr, Option, std::move(Config).getValue());<br>
>> +    Checker->parseConfiguration(Mgr, Option, std::move(Config.getValue()));<br>
>>  }<br>
>><br>
>>  bool ento::shouldRegisterGenericTaintChecker(const LangOptions &LO) {<br>
>><br>
>><br>
>> _______________________________________________<br>
>> cfe-commits mailing list<br>
>> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
>> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>