<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Kristof,<div class=""><br class=""></div><div class="">It looks like your fix didn’t address all the bots:</div><div class=""><br class=""></div><div class=""><span title="Compile Error" style="box-sizing: border-box; font-family: monospace; font-size: 14px; white-space: pre-wrap; background-color: red;" class="">/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/tools/clang/lib/Analysis/Dominators.cpp:14:48: error: explicit specialization of 'anchor' after instantiation
</span><span style="caret-color: rgb(51, 51, 51); color: rgb(51, 51, 51); font-family: monospace; font-size: 14px; white-space: pre-wrap;" class="">void CFGDominatorTreeImpl</*IsPostDom=*/true>::anchor() {}
^
/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/tools/clang/include/clang/Analysis/Analyses/Dominators.h:225:3: note: implicit instantiation first required here
ControlDependencyCalculator(CFG *cfg)
^</span><br class=""><div><br class=""></div><div>Can you please address the issue?</div><div><a href="http://green.lab.llvm.org/green/job/clang-stage2-coverage-R/4153/consoleFull" class="">http://green.lab.llvm.org/green/job/clang-stage2-coverage-R/4153/consoleFull</a></div><div><br class=""></div><div>Thanks,</div><div><br class=""></div><div>JF</div><div><br class=""></div><div><br class=""><blockquote type="cite" class=""><div class="">On Jul 3, 2019, at 5:06 AM, Kristof Umann via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Author: szelethus<br class="">Date: Wed Jul 3 05:06:10 2019<br class="">New Revision: 365030<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=365030&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=365030&view=rev</a><br class="">Log:<br class="">Make a buildbot using a buggy gcc happy<br class=""><br class="">When specializing a template in a namespace, it has to be in a namespace<br class="">block, else gcc will get confused. Hopefully this fixes the issue.<br class=""><br class=""><a href="https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480" class="">https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480</a><br class=""><br class="">Modified:<br class=""> cfe/trunk/lib/Analysis/Dominators.cpp<br class=""><br class="">Modified: cfe/trunk/lib/Analysis/Dominators.cpp<br class="">URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/Dominators.cpp?rev=365030&r1=365029&r2=365030&view=diff<br class="">==============================================================================<br class="">--- cfe/trunk/lib/Analysis/Dominators.cpp (original)<br class="">+++ cfe/trunk/lib/Analysis/Dominators.cpp Wed Jul 3 05:06:10 2019<br class="">@@ -8,10 +8,12 @@<br class=""><br class=""> #include "clang/Analysis/Analyses/Dominators.h"<br class=""><br class="">-using namespace clang;<br class="">+namespace clang {<br class=""><br class=""> template <><br class="">-void clang::CFGDominatorTreeImpl</*IsPostDom=*/true>::anchor() {}<br class="">+void CFGDominatorTreeImpl</*IsPostDom=*/true>::anchor() {}<br class=""><br class=""> template <><br class="">-void clang::CFGDominatorTreeImpl</*IsPostDom=*/false>::anchor() {}<br class="">+void CFGDominatorTreeImpl</*IsPostDom=*/false>::anchor() {}<br class="">+<br class="">+} // end of namespace clang<br class=""><br class=""><br class="">_______________________________________________<br class="">cfe-commits mailing list<br class="">cfe-commits@lists.llvm.org<br class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits<br class=""></div></div></blockquote></div><br class=""></div></body></html>