<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Thanks Richard!<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jul 8, 2019, at 12:46 PM, Richard Smith via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">Committed as r365377.</div><div dir="ltr" class=""><br class=""></div><div dir="ltr" class="">On Mon, 8 Jul 2019 at 12:43, Kristóf Umann via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:<br class=""></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto" class="">Thank you so much! Sorry for the inconvencience, I'll be that much more careful next time :)</div></blockquote><div class=""><br class=""></div><div class="">=) No worries. It's one of those pesky "no diagnostic required" cases; they're often a pain.</div><div class=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 8 Jul 2019, 21:42 Richard Smith, <<a href="mailto:richard@metafoo.co.uk" target="_blank" class="">richard@metafoo.co.uk</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class="">I'll commit the change below once my testing finishes :)</div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 8 Jul 2019 at 12:40, Kristóf Umann via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" rel="noreferrer" target="_blank" class="">cfe-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto" class=""><div class="">Noted, thanks! Gabor, could you please fix this?<br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 8 Jul 2019, 21:37 Richard Smith, <<a href="mailto:richard@metafoo.co.uk" rel="noreferrer" target="_blank" class="">richard@metafoo.co.uk</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class="">This is in any case the wrong fix. The code *is* wrong, for the reason this compiler is reporting.<div class=""><br class=""></div><div class="">The correct fix is to declare the explicit specializations in the header file:</div><div class=""><br class=""></div><div class="">template <> void CFGDominatorTreeImpl<true>::anchor();</div><div class="">template <> void CFGDominatorTreeImpl<false>::anchor();<br class=""><br class=""></div><div class="">Clang will tell you to do this under -Wundefined-func-template (which we haven't turned on by default because people get this wrong too often...).</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 8 Jul 2019 at 12:29, JF Bastien via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" rel="noreferrer noreferrer" target="_blank" class="">cfe-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="">Kristof,<div class=""><br class=""></div><div class="">It looks like your fix didn’t address all the bots:</div><div class=""><br class=""></div><div class=""><span title="Compile Error" style="box-sizing:border-box;font-family:monospace;font-size:14px;white-space:pre-wrap;background-color:red" class="">/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/tools/clang/lib/Analysis/Dominators.cpp:14:48: error: explicit specialization of 'anchor' after instantiation
</span><span style="color:rgb(51,51,51);font-family:monospace;font-size:14px;white-space:pre-wrap" class="">void CFGDominatorTreeImpl</*IsPostDom=*/true>::anchor() {}
^
/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/tools/clang/include/clang/Analysis/Analyses/Dominators.h:225:3: note: implicit instantiation first required here
ControlDependencyCalculator(CFG *cfg)
^</span><br class=""><div class=""><br class=""></div><div class="">Can you please address the issue?</div><div class=""><a href="http://green.lab.llvm.org/green/job/clang-stage2-coverage-R/4153/consoleFull" rel="noreferrer noreferrer" target="_blank" class="">http://green.lab.llvm.org/green/job/clang-stage2-coverage-R/4153/consoleFull</a></div><div class=""><br class=""></div><div class="">Thanks,</div><div class=""><br class=""></div><div class="">JF</div><div class=""><br class=""></div><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Jul 3, 2019, at 5:06 AM, Kristof Umann via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" rel="noreferrer noreferrer" target="_blank" class="">cfe-commits@lists.llvm.org</a>> wrote:</div><br class="gmail-m_-2973181692268941378m_-100415623106942058gmail-m_-2139223504384036165m_6799972720023529726gmail-m_5491834518596508129Apple-interchange-newline"><div class=""><div class="">Author: szelethus<br class="">Date: Wed Jul 3 05:06:10 2019<br class="">New Revision: 365030<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=365030&view=rev" rel="noreferrer noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=365030&view=rev</a><br class="">Log:<br class="">Make a buildbot using a buggy gcc happy<br class=""><br class="">When specializing a template in a namespace, it has to be in a namespace<br class="">block, else gcc will get confused. Hopefully this fixes the issue.<br class=""><br class=""><a href="https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480" rel="noreferrer noreferrer" target="_blank" class="">https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480</a><br class=""><br class="">Modified:<br class=""> cfe/trunk/lib/Analysis/Dominators.cpp<br class=""><br class="">Modified: cfe/trunk/lib/Analysis/Dominators.cpp<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/Dominators.cpp?rev=365030&r1=365029&r2=365030&view=diff" rel="noreferrer noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/Dominators.cpp?rev=365030&r1=365029&r2=365030&view=diff</a><br class="">==============================================================================<br class="">--- cfe/trunk/lib/Analysis/Dominators.cpp (original)<br class="">+++ cfe/trunk/lib/Analysis/Dominators.cpp Wed Jul 3 05:06:10 2019<br class="">@@ -8,10 +8,12 @@<br class=""><br class=""> #include "clang/Analysis/Analyses/Dominators.h"<br class=""><br class="">-using namespace clang;<br class="">+namespace clang {<br class=""><br class=""> template <><br class="">-void clang::CFGDominatorTreeImpl</*IsPostDom=*/true>::anchor() {}<br class="">+void CFGDominatorTreeImpl</*IsPostDom=*/true>::anchor() {}<br class=""><br class=""> template <><br class="">-void clang::CFGDominatorTreeImpl</*IsPostDom=*/false>::anchor() {}<br class="">+void CFGDominatorTreeImpl</*IsPostDom=*/false>::anchor() {}<br class="">+<br class="">+} // end of namespace clang<br class=""><br class=""><br class="">_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@lists.llvm.org" rel="noreferrer noreferrer" target="_blank" class="">cfe-commits@lists.llvm.org</a><br class=""><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class=""></div></div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" rel="noreferrer noreferrer" target="_blank" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer noreferrer noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div>
</blockquote></div></div></div>
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" rel="noreferrer" target="_blank" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div>
</blockquote></div>
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div></div>
_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits<br class=""></div></blockquote></div><br class=""></body></html>