<div dir="ltr">Thanks! And sorry about this in the first place, I did not have this warning enabled locally.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 4, 2019 at 1:28 PM Simon Pilgrim via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: rksimon<br>
Date: Tue Jun  4 04:31:45 2019<br>
New Revision: 362491<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=362491&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=362491&view=rev</a><br>
Log:<br>
Fix -Wparentheses warning. NFCI.<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/clangd/Protocol.cpp<br>
<br>
Modified: clang-tools-extra/trunk/clangd/Protocol.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/Protocol.cpp?rev=362491&r1=362490&r2=362491&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/Protocol.cpp?rev=362491&r1=362490&r2=362491&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clangd/Protocol.cpp (original)<br>
+++ clang-tools-extra/trunk/clangd/Protocol.cpp Tue Jun  4 04:31:45 2019<br>
@@ -832,8 +832,8 @@ llvm::json::Value toJSON(const Completio<br>
 }<br>
<br>
 llvm::json::Value toJSON(const ParameterInformation &PI) {<br>
-  assert(PI.labelOffsets.hasValue() ||<br>
-         !PI.labelString.empty() && "parameter information label is required");<br>
+  assert((PI.labelOffsets.hasValue() || !PI.labelString.empty()) &&<br>
+         "parameter information label is required");<br>
   llvm::json::Object Result;<br>
   if (PI.labelOffsets)<br>
     Result["label"] =<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Regards,</div><div>Ilya Biryukov</div></div></div></div></div>