<div dir="ltr">I've submitted a patch to fix this, <a href="https://reviews.llvm.org/D62445">https://reviews.llvm.org/D62445</a>.<div><br></div><div>Without it, non of the bots can build/test any plugins.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 24, 2019 at 5:47 PM Akira Hatanaka via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I reverted the patch in r361685 to make the bot green again.<br>
<br>
> On May 23, 2019, at 5:22 PM, Akira Hatanaka <<a href="mailto:ahatanaka@apple.com" target="_blank">ahatanaka@apple.com</a>> wrote:<br>
> <br>
> Hi Petr,<br>
> <br>
> This seems to have caused Analysis/checker-plugins.c to fail. Can you investigate it or revert your commit?<br>
> <br>
> <a href="http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6381/consoleFull#-5275661368254eaf0-7326-4999-85b0-388101f2d404" rel="noreferrer" target="_blank">http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6381/consoleFull#-5275661368254eaf0-7326-4999-85b0-388101f2d404</a><br>
> <br>
>> On May 21, 2019, at 5:47 PM, Petr Hosek via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
>> <br>
>> Author: phosek<br>
>> Date: Tue May 21 17:47:37 2019<br>
>> New Revision: 361340<br>
>> <br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=361340&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=361340&view=rev</a><br>
>> Log:<br>
>> [Analysis] Link library dependencies to Analysis plugins<br>
>> <br>
>> These are needed to avoid undefined symbols which aren't satisfied<br>
>> by Clang itself.<br>
>> <br>
>> Differential Revision: <a href="https://reviews.llvm.org/D62174" rel="noreferrer" target="_blank">https://reviews.llvm.org/D62174</a><br>
>> <br>
>> Modified:<br>
>>   cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt<br>
>>   cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt<br>
>>   cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt<br>
>> <br>
>> Modified: cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff</a><br>
>> ==============================================================================<br>
>> --- cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt (original)<br>
>> +++ cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt Tue May 21 17:47:37 2019<br>
>> @@ -1,11 +1,12 @@<br>
>> set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/CheckerDependencyHandlingAnalyzerPlugin.exports)<br>
>> add_llvm_library(CheckerDependencyHandlingAnalyzerPlugin MODULE CheckerDependencyHandling.cpp PLUGIN_TOOL clang)<br>
>> <br>
>> -if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN))<br>
>> +if(LLVM_ENABLE_PLUGINS)<br>
>>  target_link_libraries(CheckerDependencyHandlingAnalyzerPlugin PRIVATE<br>
>>    clangAnalysis<br>
>>    clangAST<br>
>>    clangStaticAnalyzerCore<br>
>> +    clangStaticAnalyzerFrontend<br>
>>    LLVMSupport<br>
>>    )<br>
>> endif()<br>
>> <br>
>> Modified: cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff</a><br>
>> ==============================================================================<br>
>> --- cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt (original)<br>
>> +++ cfe/trunk/test/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt Tue May 21 17:47:37 2019<br>
>> @@ -1,11 +1,12 @@<br>
>> set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/CheckerOptionHandlingAnalyzerPlugin.exports)<br>
>> add_llvm_library(CheckerOptionHandlingAnalyzerPlugin MODULE CheckerOptionHandling.cpp PLUGIN_TOOL clang)<br>
>> <br>
>> -if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN))<br>
>> +if(LLVM_ENABLE_PLUGINS)<br>
>>  target_link_libraries(CheckerOptionHandlingAnalyzerPlugin PRIVATE<br>
>>    clangAnalysis<br>
>>    clangAST<br>
>>    clangStaticAnalyzerCore<br>
>> +    clangStaticAnalyzerFrontend<br>
>>    LLVMSupport<br>
>>    )<br>
>> endif()<br>
>> <br>
>> Modified: cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt?rev=361340&r1=361339&r2=361340&view=diff</a><br>
>> ==============================================================================<br>
>> --- cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt (original)<br>
>> +++ cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt Tue May 21 17:47:37 2019<br>
>> @@ -1,11 +1,12 @@<br>
>> set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/SampleAnalyzerPlugin.exports)<br>
>> add_llvm_library(SampleAnalyzerPlugin MODULE MainCallChecker.cpp PLUGIN_TOOL clang)<br>
>> <br>
>> -if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN))<br>
>> +if(LLVM_ENABLE_PLUGINS)<br>
>>  target_link_libraries(SampleAnalyzerPlugin PRIVATE<br>
>>    clangAnalysis<br>
>>    clangAST<br>
>>    clangStaticAnalyzerCore<br>
>> +    clangStaticAnalyzerFrontend<br>
>>    LLVMSupport<br>
>>    )<br>
>> endif()<br>
>> <br>
>> <br>
>> _______________________________________________<br>
>> cfe-commits mailing list<br>
>> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
>> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
> <br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>